Conversation
Owner
|
❤️ Mocha! |
Collaborator
Author
|
Sweet then I will migrate the rest. This will take some time though. |
stoeffel
force-pushed
the
test-coverage
branch
8 times, most recently
from
c2fc006 to
895b448
Compare
Collaborator
Author
|
I migrated all tests, but it needs some review to make sure I didn't miss a test or misspelled something. |
stoeffel
force-pushed
the
test-coverage
branch
from
895b448 to
ecc4caf
Compare
Collaborator
Author
|
@epeli do you prefer a mocha reporter? I would vote for "nyan" 😄 or "dot"
|
stoeffel
force-pushed
the
test-coverage
branch
from
ecc4caf to
eb2f8cd
Compare
Collaborator
Author
|
@epeli If you have time, it would be cool if you could review this, it's a really big change 😄 |
Owner
Yeah, that's why I've been fine with qunit =) But I'll take a look at during the weekend. |
Collaborator
Author
|
@epeli did you have time to check this out? |
Collaborator
Author
|
@epeli Would be cool if we could merge or close this to not block further development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How about we move from qunit to mocha.
This would clean up our repo and allow us to have a nice code coverage report.
As an example I migrated some tests in the
testsfolder and created a new gulp task (gulp mocha).TODO