Skip to content

Commit cef16a6

Browse files
Nivaldo Bondançafacebook-github-bot
authored andcommitted
Do not print stack trace
Summary: This was missed on the changes from #476, but luckily our internal tests caught it when I tried to sent out a new release. Reviewed By: strulovich Differential Revision: D58528471 fbshipit-source-id: ea4824b295f452b1dc0f7d868664e6792ba07c9c
1 parent 96d9435 commit cef16a6

1 file changed

Lines changed: 7 additions & 10 deletions

File tree

  • core/src/main/java/com/facebook/ktfmt/cli

core/src/main/java/com/facebook/ktfmt/cli/Main.kt

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,8 @@ class Main(
7979
}
8080

8181
fun run(): Int {
82-
val processArgs = ParsedArgs.processArgs(inputArgs)
8382
val parsedArgs =
84-
when (processArgs) {
83+
when (val processArgs = ParsedArgs.processArgs(inputArgs)) {
8584
is ParseResult.Ok -> processArgs.parsedValue
8685
is ParseResult.ShowMessage -> {
8786
out.println(processArgs.message)
@@ -103,8 +102,7 @@ class Main(
103102
val alreadyFormatted = format(null, parsedArgs)
104103
if (!alreadyFormatted && parsedArgs.setExitIfChanged) EXIT_CODE_FAILURE
105104
else EXIT_CODE_SUCCESS
106-
} catch (e: Exception) {
107-
e.printStackTrace(err)
105+
} catch (_: Exception) {
108106
EXIT_CODE_FAILURE
109107
}
110108
}
@@ -116,18 +114,17 @@ class Main(
116114
return EXIT_CODE_FAILURE
117115
}
118116

119-
val retval = AtomicInteger(EXIT_CODE_SUCCESS)
117+
val returnCode = AtomicInteger(EXIT_CODE_SUCCESS)
120118
files.parallelStream().forEach {
121119
try {
122120
if (!format(it, parsedArgs) && parsedArgs.setExitIfChanged) {
123-
retval.set(EXIT_CODE_FAILURE)
121+
returnCode.set(EXIT_CODE_FAILURE)
124122
}
125-
} catch (e: Exception) {
126-
e.printStackTrace(err)
127-
retval.set(EXIT_CODE_FAILURE)
123+
} catch (_: Exception) {
124+
returnCode.set(EXIT_CODE_FAILURE)
128125
}
129126
}
130-
return retval.get()
127+
return returnCode.get()
131128
}
132129

133130
/**

0 commit comments

Comments
 (0)