Skip to content

Commit 004cb21

Browse files
Kachulio1gaearon
authored andcommitted
Short circuit the logic for exporting a module (#13392)
* short circuit some logic * revert back to ternary operator
1 parent f7a538c commit 004cb21

14 files changed

Lines changed: 14 additions & 32 deletions

File tree

packages/react-dom/index.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ const ReactDOMFB = require('./src/client/ReactDOMFB');
1111

1212
// TODO: decide on the top-level export form.
1313
// This is hacky but makes it work with both Rollup and Jest.
14-
module.exports = ReactDOMFB.default ? ReactDOMFB.default : ReactDOMFB;
14+
module.exports = ReactDOMFB.default || ReactDOMFB;

packages/react-dom/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ const ReactDOM = require('./src/client/ReactDOM');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest.
16-
module.exports = ReactDOM.default ? ReactDOM.default : ReactDOM;
16+
module.exports = ReactDOM.default || ReactDOM;

packages/react-dom/server.browser.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,4 @@ const ReactDOMServer = require('./src/server/ReactDOMServerBrowser');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest
16-
module.exports = ReactDOMServer.default
17-
? ReactDOMServer.default
18-
: ReactDOMServer;
16+
module.exports = ReactDOMServer.default || ReactDOMServer;

packages/react-dom/server.node.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,4 @@ const ReactDOMServer = require('./src/server/ReactDOMServerNode');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest
16-
module.exports = ReactDOMServer.default
17-
? ReactDOMServer.default
18-
: ReactDOMServer;
16+
module.exports = ReactDOMServer.default || ReactDOMServer;

packages/react-dom/test-utils.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,4 @@ const ReactTestUtils = require('./src/test-utils/ReactTestUtils');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest.
16-
module.exports = ReactTestUtils.default
17-
? ReactTestUtils.default
18-
: ReactTestUtils;
16+
module.exports = ReactTestUtils.default || ReactTestUtils;

packages/react-native-renderer/fabric.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ const ReactFabric = require('./src/ReactFabric');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest.
16-
module.exports = ReactFabric.default ? ReactFabric.default : ReactFabric;
16+
module.exports = ReactFabric.default || ReactFabric;

packages/react-native-renderer/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,4 @@ const ReactNativeRenderer = require('./src/ReactNativeRenderer');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest.
16-
module.exports = ReactNativeRenderer.default
17-
? ReactNativeRenderer.default
18-
: ReactNativeRenderer;
16+
module.exports = ReactNativeRenderer.default || ReactNativeRenderer;

packages/react-noop-renderer/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ const ReactNoop = require('./src/ReactNoop');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest.
16-
module.exports = ReactNoop.default ? ReactNoop.default : ReactNoop;
16+
module.exports = ReactNoop.default || ReactNoop;

packages/react-noop-renderer/persistent.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,4 @@ const ReactNoopPersistent = require('./src/ReactNoopPersistent');
1313

1414
// TODO: decide on the top-level export form.
1515
// This is hacky but makes it work with both Rollup and Jest.
16-
module.exports = ReactNoopPersistent.default
17-
? ReactNoopPersistent.default
18-
: ReactNoopPersistent;
16+
module.exports = ReactNoopPersistent.default || ReactNoopPersistent;

packages/react-reconciler/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,4 @@ const ReactFiberReconciler = require('./src/ReactFiberReconciler');
2323

2424
// TODO: decide on the top-level export form.
2525
// This is hacky but makes it work with both Rollup and Jest.
26-
module.exports = ReactFiberReconciler.default
27-
? ReactFiberReconciler.default
28-
: ReactFiberReconciler;
26+
module.exports = ReactFiberReconciler.default || ReactFiberReconciler;

0 commit comments

Comments
 (0)