Skip to content

Commit 2749fbc

Browse files
mdjastrzebskifacebook-github-bot
authored andcommitted
fix: role="searchbox" should assing "SearchField" trait on iOS (#39314)
Summary: Experimenting with Accessibility Inspector on iOS I've discovered that while when assigning `accessibilityRole="searchbox"` to a text input results in "Traits" reporting "Search Field" trait. However, when using ARIA-compatible `role="search"` such trait is not assigned, and text input will have an empty trait. Afaiu this is incorrect as using `role="search"` and `accessibilityRole="searchbox"` should equivalent effect. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> IOS FIXED - `role="searchbox"` now assigns "Search Field" accessibility trait to a view Pull Request resolved: #39314 Test Plan: No UI changes, it affects only accessibility. Reviewed By: NickGerleman Differential Revision: D49014039 Pulled By: dmytrorykun fbshipit-source-id: 5fb194e67fbf2ac339d9a746e3ce6aaed2d32558
1 parent ef3e771 commit 2749fbc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native/React/Views/RCTViewManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ @implementation RCTConvert (UIAccessibilityTraits)
9292
@"scrollbar" : @(UIAccessibilityTraitNone),
9393
@"scrollview" : @(UIAccessibilityTraitNone),
9494
@"search" : @(UIAccessibilityTraitSearchField),
95-
@"searchbox" : @(UIAccessibilityTraitNone),
95+
@"searchbox" : @(UIAccessibilityTraitSearchField),
9696
@"selected" : @(UIAccessibilityTraitSelected),
9797
@"separator" : @(UIAccessibilityTraitNone),
9898
@"slider" : @(UIAccessibilityTraitNone),

0 commit comments

Comments
 (0)