Commit 36b078c
authored
unify feature flags between fb and oss for React Native renderer (#28269)
# Affected flags:
### alwaysThrottleRetries
In RN OSS changed from `true` to `false`. This is what FB build uses.
This flag was a root cause for big perf regression internally.
### enableDeferRootSchedulingToMicrotask
In RN OSS build changed from `true` to `false`. This is what FB build
uses.
### debugRenderPhaseSideEffectsForStrictMode
Changed from true to __DEV__ in FB and OSS build. The flag is only used
in debug builds and was previously `false` in RN OSS builds
### enableUnifiedSyncLane
Changed from `__VARIANT__` to `true` in FB build. This is what OSS build
uses. This flag is shipped internally. cc @tyao1
### enableLegacyHidden
In RN FB changed from `true` to `false`. This is what OSS uses.
### allowConcurrentByDefault
In RN FB changed from `true` to `false`.
I ran `yarn flags --diff rn rn-fb` to get the difference between feature
flags and unify them.
## Before
```
yarn run v1.22.19
$ node ./scripts/flags/flags.js --diff rn rn-fb
┌───────────────────────────────────────────────┬────────┬───────┐
│ (index) │ RN OSS │ RN FB │
├───────────────────────────────────────────────┼────────┼───────┤
│ allowConcurrentByDefault │ '❌' │ '✅' │
│ debugRenderPhaseSideEffectsForStrictMode │ '❌' │ '✅' │
│ disableModulePatternComponents │ '❌' │ '✅' │
│ enableCPUSuspense │ '❌' │ '✅' │
│ enableCacheElement │ '❌' │ '✅' │
│ enableGetInspectorDataForInstanceInProduction │ '❌' │ '✅' │
│ enableLegacyHidden │ '❌' │ '✅' │
│ enableSchedulingProfiler │ '❌' │ '📊' │
│ enableUseDeferredValueInitialArg │ '❌' │ '✅' │
│ enableUseMemoCacheHook │ '❌' │ '✅' │
│ enableUseRefAccessWarning │ '❌' │ '🧪' │
│ passChildrenWhenCloningPersistedNodes │ '❌' │ '🧪' │
│ useMicrotasksForSchedulingInFabric │ '❌' │ '🧪' │
│ alwaysThrottleRetries │ '✅' │ '🧪' │
│ enableDeferRootSchedulingToMicrotask │ '✅' │ '🧪' │
│ enableUnifiedSyncLane │ '✅' │ '🧪' │
└───────────────────────────────────────────────┴────────┴───────┘
```
## After
```
yarn run v1.22.19
$ node ./scripts/flags/flags.js --diff rn rn-fb
┌───────────────────────────────────────────────┬────────┬───────┐
│ (index) │ RN OSS │ RN FB │
├───────────────────────────────────────────────┼────────┼───────┤
│ alwaysThrottleRetries │ '❌' │ '🧪' │
│ disableModulePatternComponents │ '❌' │ '✅' │
│ enableCPUSuspense │ '❌' │ '✅' │
│ enableCacheElement │ '❌' │ '✅' │
│ enableDeferRootSchedulingToMicrotask │ '❌' │ '🧪' │
│ enableGetInspectorDataForInstanceInProduction │ '❌' │ '✅' │
│ enableSchedulingProfiler │ '❌' │ '📊' │
│ enableUseDeferredValueInitialArg │ '❌' │ '✅' │
│ enableUseMemoCacheHook │ '❌' │ '✅' │
│ enableUseRefAccessWarning │ '❌' │ '🧪' │
│ passChildrenWhenCloningPersistedNodes │ '❌' │ '🧪' │
│ useMicrotasksForSchedulingInFabric │ '❌' │ '🧪' │
└───────────────────────────────────────────────┴────────┴───────┘
```1 parent ba5e6a8 commit 36b078c
5 files changed
Lines changed: 8 additions & 10 deletions
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
47 | | - | |
| 46 | + | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
52 | 51 | | |
53 | 52 | | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
0 commit comments