Skip to content

Commit 6f94ca8

Browse files
committed
[Fizz] handle throwing after abort during render (#30730)
It is possible to throw after aborting during a render and we were not properly tracking this. We use an AbortSigil to mark whether a rendering task needs to abort but the throw interrupts that and we end up handling an error on the error pathway instead. This change reworks the abort-while-rendering support to be robust to throws after calling abort DiffTrain build for [7954db9](7954db9)
1 parent b41f0cd commit 6f94ca8

36 files changed

Lines changed: 148 additions & 147 deletions

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7e8a06cf4c628be45171da52c1a8e97f9869b7ee
1+
7954db9398b9afa962167577a6c6940be3856c39
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7e8a06cf4c628be45171da52c1a8e97f9869b7ee
1+
7954db9398b9afa962167577a6c6940be3856c39

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2001,7 +2001,7 @@ __DEV__ &&
20012001
exports.useTransition = function () {
20022002
return resolveDispatcher().useTransition();
20032003
};
2004-
exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
2004+
exports.version = "19.0.0-www-classic-7954db93-20240816";
20052005
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
20062006
"function" ===
20072007
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1981,7 +1981,7 @@ __DEV__ &&
19811981
exports.useTransition = function () {
19821982
return resolveDispatcher().useTransition();
19831983
};
1984-
exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
1984+
exports.version = "19.0.0-www-modern-7954db93-20240816";
19851985
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19861986
"function" ===
19871987
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
668+
exports.version = "19.0.0-www-classic-7954db93-20240816";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
668+
exports.version = "19.0.0-www-modern-7954db93-20240816";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
672+
exports.version = "19.0.0-www-classic-7954db93-20240816";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
672+
exports.version = "19.0.0-www-modern-7954db93-20240816";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16776,11 +16776,11 @@ __DEV__ &&
1677616776
(function () {
1677716777
var internals = {
1677816778
bundleType: 1,
16779-
version: "19.0.0-www-classic-7e8a06cf-20240815",
16779+
version: "19.0.0-www-classic-7954db93-20240816",
1678016780
rendererPackageName: "react-art",
1678116781
currentDispatcherRef: ReactSharedInternals,
1678216782
findFiberByHostInstance: getInstanceFromNode,
16783-
reconcilerVersion: "19.0.0-www-classic-7e8a06cf-20240815"
16783+
reconcilerVersion: "19.0.0-www-classic-7954db93-20240816"
1678416784
};
1678516785
internals.overrideHookState = overrideHookState;
1678616786
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16814,7 +16814,7 @@ __DEV__ &&
1681416814
exports.Shape = Shape;
1681516815
exports.Surface = Surface;
1681616816
exports.Text = Text;
16817-
exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
16817+
exports.version = "19.0.0-www-classic-7954db93-20240816";
1681816818
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1681916819
"function" ===
1682016820
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16189,11 +16189,11 @@ __DEV__ &&
1618916189
(function () {
1619016190
var internals = {
1619116191
bundleType: 1,
16192-
version: "19.0.0-www-modern-7e8a06cf-20240815",
16192+
version: "19.0.0-www-modern-7954db93-20240816",
1619316193
rendererPackageName: "react-art",
1619416194
currentDispatcherRef: ReactSharedInternals,
1619516195
findFiberByHostInstance: getInstanceFromNode,
16196-
reconcilerVersion: "19.0.0-www-modern-7e8a06cf-20240815"
16196+
reconcilerVersion: "19.0.0-www-modern-7954db93-20240816"
1619716197
};
1619816198
internals.overrideHookState = overrideHookState;
1619916199
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16227,7 +16227,7 @@ __DEV__ &&
1622716227
exports.Shape = Shape;
1622816228
exports.Surface = Surface;
1622916229
exports.Text = Text;
16230-
exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
16230+
exports.version = "19.0.0-www-modern-7954db93-20240816";
1623116231
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1623216232
"function" ===
1623316233
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)