Skip to content

Commit 737b75e

Browse files
committed
Don't update textarea defaultValue and input checked unnecessarily (#26580)
In #26573 I changed it so that textareas get their defaultValue reset if you don't specify one. However, the way that was implemented, it always set it for any update even if it hasn't changed. We have a test for that, but that test only works if no properties update at all so that no update was scheduled. This fixes the test so that it updates some unrelated prop. I also found a test for `checked` that needed a similar fix. Interestingly, we don't do this deduping for `defaultValue` or `defaultChecked` on inputs and there's no test for that. DiffTrain build for commit 9a9da77.
1 parent a00c8ed commit 737b75e

13 files changed

Lines changed: 19 additions & 19 deletions

File tree

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23888,7 +23888,7 @@ function createFiberRoot(
2388823888
return root;
2388923889
}
2389023890

23891-
var ReactVersion = "18.3.0-next-e5146cb52-20230409";
23891+
var ReactVersion = "18.3.0-next-9a9da7721-20230409";
2389223892

2389323893
// Might add PROFILE later.
2389423894

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8688,7 +8688,7 @@ var devToolsConfig$jscomp$inline_1028 = {
86888688
throw Error("TestRenderer does not support findFiberByHostInstance()");
86898689
},
86908690
bundleType: 0,
8691-
version: "18.3.0-next-e5146cb52-20230409",
8691+
version: "18.3.0-next-9a9da7721-20230409",
86928692
rendererPackageName: "react-test-renderer"
86938693
};
86948694
var internals$jscomp$inline_1220 = {
@@ -8719,7 +8719,7 @@ var internals$jscomp$inline_1220 = {
87198719
scheduleRoot: null,
87208720
setRefreshHandler: null,
87218721
getCurrentFiber: null,
8722-
reconcilerVersion: "18.3.0-next-e5146cb52-20230409"
8722+
reconcilerVersion: "18.3.0-next-9a9da7721-20230409"
87238723
};
87248724
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
87258725
var hook$jscomp$inline_1221 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9114,7 +9114,7 @@ var devToolsConfig$jscomp$inline_1070 = {
91149114
throw Error("TestRenderer does not support findFiberByHostInstance()");
91159115
},
91169116
bundleType: 0,
9117-
version: "18.3.0-next-e5146cb52-20230409",
9117+
version: "18.3.0-next-9a9da7721-20230409",
91189118
rendererPackageName: "react-test-renderer"
91199119
};
91209120
var internals$jscomp$inline_1261 = {
@@ -9145,7 +9145,7 @@ var internals$jscomp$inline_1261 = {
91459145
scheduleRoot: null,
91469146
setRefreshHandler: null,
91479147
getCurrentFiber: null,
9148-
reconcilerVersion: "18.3.0-next-e5146cb52-20230409"
9148+
reconcilerVersion: "18.3.0-next-9a9da7721-20230409"
91499149
};
91509150
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91519151
var hook$jscomp$inline_1262 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-e5146cb52-20230409";
30+
var ReactVersion = "18.3.0-next-9a9da7721-20230409";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-e5146cb52-20230409";
642+
exports.version = "18.3.0-next-9a9da7721-20230409";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-e5146cb52-20230409";
645+
exports.version = "18.3.0-next-9a9da7721-20230409";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e5146cb5250be1a4e66511af91549859b36ed488
1+
9a9da7721e5b73a8af242807e463e2af842c58ee

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27184,7 +27184,7 @@ function createFiberRoot(
2718427184
return root;
2718527185
}
2718627186

27187-
var ReactVersion = "18.3.0-next-e5146cb52-20230409";
27187+
var ReactVersion = "18.3.0-next-9a9da7721-20230409";
2718827188

2718927189
function createPortal$1(
2719027190
children,

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9555,7 +9555,7 @@ var roots = new Map(),
95559555
devToolsConfig$jscomp$inline_1052 = {
95569556
findFiberByHostInstance: getInstanceFromNode,
95579557
bundleType: 0,
9558-
version: "18.3.0-next-e5146cb52-20230409",
9558+
version: "18.3.0-next-9a9da7721-20230409",
95599559
rendererPackageName: "react-native-renderer",
95609560
rendererConfig: {
95619561
getInspectorDataForViewTag: function () {
@@ -9597,7 +9597,7 @@ var internals$jscomp$inline_1297 = {
95979597
scheduleRoot: null,
95989598
setRefreshHandler: null,
95999599
getCurrentFiber: null,
9600-
reconcilerVersion: "18.3.0-next-e5146cb52-20230409"
9600+
reconcilerVersion: "18.3.0-next-9a9da7721-20230409"
96019601
};
96029602
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96039603
var hook$jscomp$inline_1298 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10264,7 +10264,7 @@ var roots = new Map(),
1026410264
devToolsConfig$jscomp$inline_1130 = {
1026510265
findFiberByHostInstance: getInstanceFromNode,
1026610266
bundleType: 0,
10267-
version: "18.3.0-next-e5146cb52-20230409",
10267+
version: "18.3.0-next-9a9da7721-20230409",
1026810268
rendererPackageName: "react-native-renderer",
1026910269
rendererConfig: {
1027010270
getInspectorDataForViewTag: function () {
@@ -10319,7 +10319,7 @@ var roots = new Map(),
1031910319
scheduleRoot: null,
1032010320
setRefreshHandler: null,
1032110321
getCurrentFiber: null,
10322-
reconcilerVersion: "18.3.0-next-e5146cb52-20230409"
10322+
reconcilerVersion: "18.3.0-next-9a9da7721-20230409"
1032310323
});
1032410324
exports.createPortal = function (children, containerTag) {
1032510325
return createPortal$1(

0 commit comments

Comments
 (0)