Commit 737b75e
committed
Don't update textarea defaultValue and input checked unnecessarily (#26580)
In #26573 I changed it so that textareas get their defaultValue reset if
you don't specify one.
However, the way that was implemented, it always set it for any update
even if it hasn't changed.
We have a test for that, but that test only works if no properties
update at all so that no update was scheduled. This fixes the test so
that it updates some unrelated prop.
I also found a test for `checked` that needed a similar fix.
Interestingly, we don't do this deduping for `defaultValue` or
`defaultChecked` on inputs and there's no test for that.
DiffTrain build for commit 9a9da77.1 parent a00c8ed commit 737b75e
13 files changed
Lines changed: 19 additions & 19 deletions
File tree
- compiled-rn/facebook-fbsource/xplat/js
- RKJSModules/vendor
- react-test-renderer/cjs
- react/cjs
- react-native-github/Libraries/Renderer
- implementations
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23888 | 23888 | | |
23889 | 23889 | | |
23890 | 23890 | | |
23891 | | - | |
| 23891 | + | |
23892 | 23892 | | |
23893 | 23893 | | |
23894 | 23894 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8688 | 8688 | | |
8689 | 8689 | | |
8690 | 8690 | | |
8691 | | - | |
| 8691 | + | |
8692 | 8692 | | |
8693 | 8693 | | |
8694 | 8694 | | |
| |||
8719 | 8719 | | |
8720 | 8720 | | |
8721 | 8721 | | |
8722 | | - | |
| 8722 | + | |
8723 | 8723 | | |
8724 | 8724 | | |
8725 | 8725 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9114 | 9114 | | |
9115 | 9115 | | |
9116 | 9116 | | |
9117 | | - | |
| 9117 | + | |
9118 | 9118 | | |
9119 | 9119 | | |
9120 | 9120 | | |
| |||
9145 | 9145 | | |
9146 | 9146 | | |
9147 | 9147 | | |
9148 | | - | |
| 9148 | + | |
9149 | 9149 | | |
9150 | 9150 | | |
9151 | 9151 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
639 | 639 | | |
640 | 640 | | |
641 | 641 | | |
642 | | - | |
| 642 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
642 | 642 | | |
643 | 643 | | |
644 | 644 | | |
645 | | - | |
| 645 | + | |
646 | 646 | | |
647 | 647 | | |
648 | 648 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27184 | 27184 | | |
27185 | 27185 | | |
27186 | 27186 | | |
27187 | | - | |
| 27187 | + | |
27188 | 27188 | | |
27189 | 27189 | | |
27190 | 27190 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9555 | 9555 | | |
9556 | 9556 | | |
9557 | 9557 | | |
9558 | | - | |
| 9558 | + | |
9559 | 9559 | | |
9560 | 9560 | | |
9561 | 9561 | | |
| |||
9597 | 9597 | | |
9598 | 9598 | | |
9599 | 9599 | | |
9600 | | - | |
| 9600 | + | |
9601 | 9601 | | |
9602 | 9602 | | |
9603 | 9603 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10264 | 10264 | | |
10265 | 10265 | | |
10266 | 10266 | | |
10267 | | - | |
| 10267 | + | |
10268 | 10268 | | |
10269 | 10269 | | |
10270 | 10270 | | |
| |||
10319 | 10319 | | |
10320 | 10320 | | |
10321 | 10321 | | |
10322 | | - | |
| 10322 | + | |
10323 | 10323 | | |
10324 | 10324 | | |
10325 | 10325 | | |
| |||
0 commit comments