Commit 7b7ffbd
committed
[Fiber] Log Component Effects to Performance Track (#30983)
Stacked on #30981. Same as #30967 but for effects.
This logs a tree of components using `performance.measure()`.
In addition to the previous render phase this logs one tree for each
commit phase:
- Mutation Phase
- Layout Effect
- Passive Unmounts
- Passive Mounts
I currently skip the Before Mutation phase since the snapshots are so
unusual it's not worth creating trees for those.
The mechanism is that I reuse the timings we track for
`enableProfilerCommitHooks`. I track first and last effect timestamp
within each component subtree. Then on the way up do we log the entry.
This means that we don't include overhead to find our way down to a
component and that we don't need to add any additional overhead by
reading timestamps.
To ensure that the entries get ordered correctly we need to ensure that
the start time of each parent is slightly before the inner one.
DiffTrain build for [e1c2090](e1c2090)1 parent 2acc36c commit 7b7ffbd
34 files changed
Lines changed: 185 additions & 191 deletions
File tree
- compiled/facebook-www
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2000 | 2000 | | |
2001 | 2001 | | |
2002 | 2002 | | |
2003 | | - | |
| 2003 | + | |
2004 | 2004 | | |
2005 | 2005 | | |
2006 | 2006 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1980 | 1980 | | |
1981 | 1981 | | |
1982 | 1982 | | |
1983 | | - | |
| 1983 | + | |
1984 | 1984 | | |
1985 | 1985 | | |
1986 | 1986 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
665 | 665 | | |
666 | 666 | | |
667 | 667 | | |
668 | | - | |
| 668 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
665 | 665 | | |
666 | 666 | | |
667 | 667 | | |
668 | | - | |
| 668 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
| 672 | + | |
673 | 673 | | |
674 | 674 | | |
675 | 675 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
| 672 | + | |
673 | 673 | | |
674 | 674 | | |
675 | 675 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17026 | 17026 | | |
17027 | 17027 | | |
17028 | 17028 | | |
17029 | | - | |
| 17029 | + | |
17030 | 17030 | | |
17031 | 17031 | | |
17032 | 17032 | | |
17033 | | - | |
| 17033 | + | |
17034 | 17034 | | |
17035 | 17035 | | |
17036 | 17036 | | |
| |||
17064 | 17064 | | |
17065 | 17065 | | |
17066 | 17066 | | |
17067 | | - | |
| 17067 | + | |
17068 | 17068 | | |
17069 | 17069 | | |
17070 | 17070 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16472 | 16472 | | |
16473 | 16473 | | |
16474 | 16474 | | |
16475 | | - | |
| 16475 | + | |
16476 | 16476 | | |
16477 | 16477 | | |
16478 | 16478 | | |
16479 | | - | |
| 16479 | + | |
16480 | 16480 | | |
16481 | 16481 | | |
16482 | 16482 | | |
| |||
16510 | 16510 | | |
16511 | 16511 | | |
16512 | 16512 | | |
16513 | | - | |
| 16513 | + | |
16514 | 16514 | | |
16515 | 16515 | | |
16516 | 16516 | | |
| |||
0 commit comments