Skip to content

Commit 7b7ffbd

Browse files
committed
[Fiber] Log Component Effects to Performance Track (#30983)
Stacked on #30981. Same as #30967 but for effects. This logs a tree of components using `performance.measure()`. In addition to the previous render phase this logs one tree for each commit phase: - Mutation Phase - Layout Effect - Passive Unmounts - Passive Mounts I currently skip the Before Mutation phase since the snapshots are so unusual it's not worth creating trees for those. The mechanism is that I reuse the timings we track for `enableProfilerCommitHooks`. I track first and last effect timestamp within each component subtree. Then on the way up do we log the entry. This means that we don't include overhead to find our way down to a component and that we don't need to add any additional overhead by reading timestamps. To ensure that the entries get ordered correctly we need to ensure that the start time of each parent is slightly before the inner one. DiffTrain build for [e1c2090](e1c2090)
1 parent 2acc36c commit 7b7ffbd

34 files changed

Lines changed: 185 additions & 191 deletions

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
15da9174518f18f82869767ebe2a21be2fc8bd90
1+
e1c20902c39d1dfe2649185622f2f21b526e2be2
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
15da9174518f18f82869767ebe2a21be2fc8bd90
1+
e1c20902c39d1dfe2649185622f2f21b526e2be2

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2000,7 +2000,7 @@ __DEV__ &&
20002000
exports.useTransition = function () {
20012001
return resolveDispatcher().useTransition();
20022002
};
2003-
exports.version = "19.0.0-www-classic-15da9174-20240917";
2003+
exports.version = "19.0.0-www-classic-e1c20902-20240917";
20042004
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
20052005
"function" ===
20062006
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1980,7 +1980,7 @@ __DEV__ &&
19801980
exports.useTransition = function () {
19811981
return resolveDispatcher().useTransition();
19821982
};
1983-
exports.version = "19.0.0-www-modern-15da9174-20240917";
1983+
exports.version = "19.0.0-www-modern-e1c20902-20240917";
19841984
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19851985
"function" ===
19861986
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-classic-15da9174-20240917";
668+
exports.version = "19.0.0-www-classic-e1c20902-20240917";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
665665
exports.useTransition = function () {
666666
return ReactSharedInternals.H.useTransition();
667667
};
668-
exports.version = "19.0.0-www-modern-15da9174-20240917";
668+
exports.version = "19.0.0-www-modern-e1c20902-20240917";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-classic-15da9174-20240917";
672+
exports.version = "19.0.0-www-classic-e1c20902-20240917";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
669669
exports.useTransition = function () {
670670
return ReactSharedInternals.H.useTransition();
671671
};
672-
exports.version = "19.0.0-www-modern-15da9174-20240917";
672+
exports.version = "19.0.0-www-modern-e1c20902-20240917";
673673
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
674674
"function" ===
675675
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17026,11 +17026,11 @@ __DEV__ &&
1702617026
(function () {
1702717027
var internals = {
1702817028
bundleType: 1,
17029-
version: "19.0.0-www-classic-15da9174-20240917",
17029+
version: "19.0.0-www-classic-e1c20902-20240917",
1703017030
rendererPackageName: "react-art",
1703117031
currentDispatcherRef: ReactSharedInternals,
1703217032
findFiberByHostInstance: getInstanceFromNode,
17033-
reconcilerVersion: "19.0.0-www-classic-15da9174-20240917"
17033+
reconcilerVersion: "19.0.0-www-classic-e1c20902-20240917"
1703417034
};
1703517035
internals.overrideHookState = overrideHookState;
1703617036
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -17064,7 +17064,7 @@ __DEV__ &&
1706417064
exports.Shape = Shape;
1706517065
exports.Surface = Surface;
1706617066
exports.Text = Text;
17067-
exports.version = "19.0.0-www-classic-15da9174-20240917";
17067+
exports.version = "19.0.0-www-classic-e1c20902-20240917";
1706817068
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1706917069
"function" ===
1707017070
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16472,11 +16472,11 @@ __DEV__ &&
1647216472
(function () {
1647316473
var internals = {
1647416474
bundleType: 1,
16475-
version: "19.0.0-www-modern-15da9174-20240917",
16475+
version: "19.0.0-www-modern-e1c20902-20240917",
1647616476
rendererPackageName: "react-art",
1647716477
currentDispatcherRef: ReactSharedInternals,
1647816478
findFiberByHostInstance: getInstanceFromNode,
16479-
reconcilerVersion: "19.0.0-www-modern-15da9174-20240917"
16479+
reconcilerVersion: "19.0.0-www-modern-e1c20902-20240917"
1648016480
};
1648116481
internals.overrideHookState = overrideHookState;
1648216482
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16510,7 +16510,7 @@ __DEV__ &&
1651016510
exports.Shape = Shape;
1651116511
exports.Surface = Surface;
1651216512
exports.Text = Text;
16513-
exports.version = "19.0.0-www-modern-15da9174-20240917";
16513+
exports.version = "19.0.0-www-modern-e1c20902-20240917";
1651416514
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1651516515
"function" ===
1651616516
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)