Update tests

Author: elicwhite

packages/react-native-renderer/src/ReactFabricHostConfig.js

@@ -40,7 +40,6 @@ import {
   completeRoot,
   registerEventHandler,
 } from 'FabricUIManager';
-import UIManager from 'UIManager';
 
 // Counter for uniquely identifying views.
 // % 10 === 1 means it is a rootTag.

packages/react-native-renderer/src/__mocks__/UIManager.js

@@ -153,9 +153,40 @@ const RCTUIManager = {
     views.get(parentTag).children.forEach(tag => removeChild(parentTag, tag));
   }),
   replaceExistingNonRootView: jest.fn(),
-  measure: jest.fn(),
-  measureInWindow: jest.fn(),
-  measureLayout: jest.fn(),
+  measure: jest.fn(function measure(tag, callback) {
+    invariant(
+      typeof tag === 'number',
+      'Expected tag to be a number, was passed %s',
+      tag,
+    );
+    callback(10, 10, 100, 100, 0, 0);
+  }),
+  measureInWindow: jest.fn(function measureInWindow(tag, callback) {
+    invariant(
+      typeof tag === 'number',
+      'Expected tag to be a number, was passed %s',
+      tag,
+    );
+    callback(10, 10, 100, 100);
+  }),
+  measureLayout: jest.fn(function measureLayout(
+    tag,
+    relativeTag,
+    fail,
+    success,
+  ) {
+    invariant(
+      typeof tag === 'number',
+      'Expected tag to be a number, was passed %s',
+      tag,
+    );
+    invariant(
+      typeof relativeTag === 'number',
+      'Expected relativeTag to be a number, was passed %s',
+      relativeTag,
+    );
+    success(1, 1, 100, 100);
+  }),
   __takeSnapshot: jest.fn(),
 };
 

packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js

@@ -282,20 +282,11 @@ describe('ReactNative', () => {
       );
 
       expect(UIManager.measure).not.toBeCalled();
-
       const successCallback = jest.fn();
       viewRef.measure(successCallback);
-
       expect(UIManager.measure).toHaveBeenCalledTimes(1);
-      expect(UIManager.measure).toHaveBeenCalledWith(
-        expect.any(Number),
-        expect.any(Function),
-      );
-
-      const args = UIManager.measure.mock.calls[0];
-      expect(successCallback).not.toBeCalled();
-      args[1]('success');
-      expect(successCallback).toBeCalledWith('success');
+      expect(successCallback).toHaveBeenCalledTimes(1);
+      expect(successCallback).toHaveBeenCalledWith(10, 10, 100, 100, 0, 0);
     });
   });
 
@@ -332,20 +323,11 @@ describe('ReactNative', () => {
       );
 
       expect(UIManager.measureInWindow).not.toBeCalled();
-
       const successCallback = jest.fn();
       viewRef.measureInWindow(successCallback);
-
       expect(UIManager.measureInWindow).toHaveBeenCalledTimes(1);
-      expect(UIManager.measureInWindow).toHaveBeenCalledWith(
-        expect.any(Number),
-        expect.any(Function),
-      );
-
-      const args = UIManager.measureInWindow.mock.calls[0];
-      expect(successCallback).not.toBeCalled();
-      args[1]('success');
-      expect(successCallback).toBeCalledWith('success');
+      expect(successCallback).toHaveBeenCalledTimes(1);
+      expect(successCallback).toHaveBeenCalledWith(10, 10, 100, 100);
     });
   });
 
@@ -369,7 +351,7 @@ describe('ReactNative', () => {
     });
 
     [View, Subclass, CreateClass].forEach(Component => {
-      UIManager.measureLayout.mockReset();
+      UIManager.measureLayout.mockClear();
 
       let viewRef;
       let otherRef;
@@ -391,33 +373,16 @@ describe('ReactNative', () => {
       );
 
       expect(UIManager.measureLayout).not.toBeCalled();
-
       const successCallback = jest.fn();
       const failureCallback = jest.fn();
       viewRef.measureLayout(
         ReactNative.findNodeHandle(otherRef),
         successCallback,
         failureCallback,
       );
-
       expect(UIManager.measureLayout).toHaveBeenCalledTimes(1);
-      expect(UIManager.measureLayout).toHaveBeenCalledWith(
-        expect.any(Number),
-        expect.any(Number),
-        expect.any(Function),
-        expect.any(Function),
-      );
-
-      const args = UIManager.measureLayout.mock.calls[0];
-      expect(args[0]).not.toEqual(args[1]);
-      expect(successCallback).not.toBeCalled();
-      expect(failureCallback).not.toBeCalled();
-      args[2]('fail');
-      expect(failureCallback).toBeCalledWith('fail');
-
-      expect(successCallback).not.toBeCalled();
-      args[3]('success');
-      expect(successCallback).toBeCalledWith('success');
+      expect(successCallback).toHaveBeenCalledTimes(1);
+      expect(successCallback).toHaveBeenCalledWith(1, 1, 100, 100);
     });
   });
 
@@ -428,7 +393,7 @@ describe('ReactNative', () => {
     }));
 
     [View].forEach(Component => {
-      UIManager.measureLayout.mockReset();
+      UIManager.measureLayout.mockClear();
 
       let viewRef;
       let otherRef;
@@ -450,29 +415,12 @@ describe('ReactNative', () => {
       );
 
       expect(UIManager.measureLayout).not.toBeCalled();
-
       const successCallback = jest.fn();
       const failureCallback = jest.fn();
       viewRef.measureLayout(otherRef, successCallback, failureCallback);
-
       expect(UIManager.measureLayout).toHaveBeenCalledTimes(1);
-      expect(UIManager.measureLayout).toHaveBeenCalledWith(
-        expect.any(Number),
-        expect.any(Number),
-        expect.any(Function),
-        expect.any(Function),
-      );
-
-      const args = UIManager.measureLayout.mock.calls[0];
-      expect(args[0]).not.toEqual(args[1]);
-      expect(successCallback).not.toBeCalled();
-      expect(failureCallback).not.toBeCalled();
-      args[2]('fail');
-      expect(failureCallback).toBeCalledWith('fail');
-
-      expect(successCallback).not.toBeCalled();
-      args[3]('success');
-      expect(successCallback).toBeCalledWith('success');
+      expect(successCallback).toHaveBeenCalledTimes(1);
+      expect(successCallback).toHaveBeenCalledWith(1, 1, 100, 100);
     });
   });