Skip to content

Commit afc71a4

Browse files
committed
Fix false "unknown property" warnings for events in SSR
1 parent 171149a commit afc71a4

3 files changed

Lines changed: 94 additions & 82 deletions

File tree

scripts/rollup/results.json

Lines changed: 82 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -1,60 +1,60 @@
11
{
22
"bundleSizes": {
33
"react.development.js (UMD_DEV)": {
4-
"size": 65104,
5-
"gzip": 16679
4+
"size": 65928,
5+
"gzip": 16792
66
},
77
"react.production.min.js (UMD_PROD)": {
8-
"size": 6478,
9-
"gzip": 2700
8+
"size": 6738,
9+
"gzip": 2759
1010
},
1111
"react.development.js (NODE_DEV)": {
12-
"size": 55397,
13-
"gzip": 14325
12+
"size": 56228,
13+
"gzip": 14438
1414
},
1515
"react.production.min.js (NODE_PROD)": {
16-
"size": 5343,
17-
"gzip": 2268
16+
"size": 5598,
17+
"gzip": 2334
1818
},
1919
"React-dev.js (FB_DEV)": {
20-
"size": 52655,
21-
"gzip": 13543
20+
"size": 53485,
21+
"gzip": 13653
2222
},
2323
"React-prod.js (FB_PROD)": {
24-
"size": 24178,
25-
"gzip": 6601
24+
"size": 25016,
25+
"gzip": 6705
2626
},
2727
"react-dom.development.js (UMD_DEV)": {
28-
"size": 624799,
29-
"gzip": 142849
28+
"size": 630080,
29+
"gzip": 143727
3030
},
3131
"react-dom.production.min.js (UMD_PROD)": {
32-
"size": 125896,
33-
"gzip": 40026
32+
"size": 127001,
33+
"gzip": 40233
3434
},
3535
"react-dom.development.js (NODE_DEV)": {
36-
"size": 584197,
37-
"gzip": 133211
36+
"size": 589474,
37+
"gzip": 134087
3838
},
3939
"react-dom.production.min.js (NODE_PROD)": {
40-
"size": 122812,
41-
"gzip": 38953
40+
"size": 123917,
41+
"gzip": 39159
4242
},
4343
"ReactDOMFiber-dev.js (FB_DEV)": {
44-
"size": 583480,
45-
"gzip": 133238
44+
"size": 588677,
45+
"gzip": 134228
4646
},
4747
"ReactDOMFiber-prod.js (FB_PROD)": {
48-
"size": 426550,
49-
"gzip": 96621
48+
"size": 429198,
49+
"gzip": 96890
5050
},
5151
"react-dom-test-utils.development.js (NODE_DEV)": {
52-
"size": 54887,
53-
"gzip": 14087
52+
"size": 55880,
53+
"gzip": 14123
5454
},
5555
"ReactTestUtils-dev.js (FB_DEV)": {
56-
"size": 54766,
57-
"gzip": 14049
56+
"size": 55759,
57+
"gzip": 14090
5858
},
5959
"ReactDOMServerStack-dev.js (FB_DEV)": {
6060
"size": 460810,
@@ -65,20 +65,20 @@
6565
"gzip": 81957
6666
},
6767
"react-dom-server.development.js (UMD_DEV)": {
68-
"size": 120136,
69-
"gzip": 30487
68+
"size": 285221,
69+
"gzip": 71744
7070
},
7171
"react-dom-server.production.min.js (UMD_PROD)": {
72-
"size": 20342,
73-
"gzip": 7828
72+
"size": 20365,
73+
"gzip": 7841
7474
},
7575
"react-dom-server.development.js (NODE_DEV)": {
76-
"size": 89286,
77-
"gzip": 23069
76+
"size": 245104,
77+
"gzip": 62207
7878
},
7979
"react-dom-server.production.min.js (NODE_PROD)": {
80-
"size": 18848,
81-
"gzip": 7292
80+
"size": 18871,
81+
"gzip": 7306
8282
},
8383
"ReactDOMServerStream-dev.js (FB_DEV)": {
8484
"size": 264750,
@@ -89,52 +89,52 @@
8989
"gzip": 51047
9090
},
9191
"react-art.development.js (UMD_DEV)": {
92-
"size": 362951,
93-
"gzip": 80594
92+
"size": 368249,
93+
"gzip": 81441
9494
},
9595
"react-art.production.min.js (UMD_PROD)": {
96-
"size": 98449,
97-
"gzip": 30150
96+
"size": 99307,
97+
"gzip": 30380
9898
},
9999
"react-art.development.js (NODE_DEV)": {
100-
"size": 284322,
101-
"gzip": 60517
100+
"size": 289616,
101+
"gzip": 61392
102102
},
103103
"react-art.production.min.js (NODE_PROD)": {
104-
"size": 60011,
105-
"gzip": 18244
104+
"size": 60869,
105+
"gzip": 18455
106106
},
107107
"ReactARTFiber-dev.js (FB_DEV)": {
108-
"size": 283755,
109-
"gzip": 60435
108+
"size": 288969,
109+
"gzip": 61245
110110
},
111111
"ReactARTFiber-prod.js (FB_PROD)": {
112-
"size": 217346,
113-
"gzip": 45283
112+
"size": 219348,
113+
"gzip": 45493
114114
},
115115
"ReactNativeStack-dev.js (RN_DEV)": {
116-
"size": 186585,
117-
"gzip": 36205
116+
"size": 188669,
117+
"gzip": 36584
118118
},
119119
"ReactNativeStack-prod.js (RN_PROD)": {
120-
"size": 136231,
121-
"gzip": 26184
120+
"size": 137218,
121+
"gzip": 26349
122122
},
123123
"ReactNativeFiber-dev.js (RN_DEV)": {
124-
"size": 284554,
125-
"gzip": 51697
124+
"size": 289078,
125+
"gzip": 52376
126126
},
127127
"ReactNativeFiber-prod.js (RN_PROD)": {
128-
"size": 220157,
129-
"gzip": 38484
128+
"size": 223104,
129+
"gzip": 38918
130130
},
131131
"react-test-renderer.development.js (NODE_DEV)": {
132-
"size": 281507,
133-
"gzip": 59442
132+
"size": 286803,
133+
"gzip": 60296
134134
},
135135
"ReactTestRendererFiber-dev.js (FB_DEV)": {
136-
"size": 280931,
137-
"gzip": 59364
136+
"size": 286147,
137+
"gzip": 60150
138138
},
139139
"react-test-renderer-shallow.development.js (NODE_DEV)": {
140140
"size": 10302,
@@ -145,8 +145,8 @@
145145
"gzip": 2541
146146
},
147147
"react-noop-renderer.development.js (NODE_DEV)": {
148-
"size": 275613,
149-
"gzip": 57864
148+
"size": 280903,
149+
"gzip": 58709
150150
},
151151
"ReactHTMLString-dev.js (FB_DEV)": {
152152
"size": 265654,
@@ -181,20 +181,20 @@
181181
"gzip": 50920
182182
},
183183
"ReactDOMServer-dev.js (FB_DEV)": {
184-
"size": 88798,
185-
"gzip": 23020
184+
"size": 243980,
185+
"gzip": 62043
186186
},
187187
"ReactDOMServer-prod.js (FB_PROD)": {
188-
"size": 49545,
189-
"gzip": 13626
188+
"size": 49640,
189+
"gzip": 13644
190190
},
191191
"react-dom-node-stream.development.js (NODE_DEV)": {
192-
"size": 90980,
193-
"gzip": 23577
192+
"size": 91741,
193+
"gzip": 23757
194194
},
195195
"react-dom-node-stream.production.min.js (NODE_PROD)": {
196-
"size": 19785,
197-
"gzip": 7628
196+
"size": 19808,
197+
"gzip": 7646
198198
},
199199
"ReactDOMNodeStream-dev.js (FB_DEV)": {
200200
"size": 264918,
@@ -205,28 +205,28 @@
205205
"gzip": 50956
206206
},
207207
"react-dom-unstable-native-dependencies.development.js (UMD_DEV)": {
208-
"size": 84047,
209-
"gzip": 21057
208+
"size": 87125,
209+
"gzip": 21688
210210
},
211211
"react-dom-unstable-native-dependencies.production.min.js (UMD_PROD)": {
212-
"size": 18315,
213-
"gzip": 5967
212+
"size": 18899,
213+
"gzip": 6159
214214
},
215215
"react-dom-unstable-native-dependencies.development.js (NODE_DEV)": {
216-
"size": 77475,
217-
"gzip": 19101
216+
"size": 80545,
217+
"gzip": 19735
218218
},
219219
"react-dom-unstable-native-dependencies.production.min.js (NODE_PROD)": {
220-
"size": 16588,
221-
"gzip": 5332
220+
"size": 17154,
221+
"gzip": 5513
222222
},
223223
"ReactDOMUnstableNativeDependencies-dev.js (FB_DEV)": {
224-
"size": 77189,
225-
"gzip": 19061
224+
"size": 79684,
225+
"gzip": 19612
226226
},
227227
"ReactDOMUnstableNativeDependencies-prod.js (FB_PROD)": {
228-
"size": 65908,
229-
"gzip": 15704
228+
"size": 67005,
229+
"gzip": 15921
230230
}
231231
}
232232
}

src/renderers/dom/ReactDOMServerEntry.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ var ReactDOMStringRenderer = require('ReactDOMStringRenderer');
1515
var ReactVersion = require('ReactVersion');
1616

1717
require('ReactDOMInjection');
18+
if (__DEV__) {
19+
// Server side attribute validation needs to know about event names,
20+
// so we have to inject the event system. We only need it in development.
21+
// TODO: this is gross. Find another way.
22+
require('ReactDOMClientInjection');
23+
}
1824

1925
module.exports = {
2026
renderToString: ReactDOMStringRenderer.renderToString,

src/renderers/dom/ReactDOMServerStackEntry.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ var ReactVersion = require('ReactVersion');
1616

1717
require('ReactDOMInjection');
1818
require('ReactDOMStackInjection');
19+
if (__DEV__) {
20+
// Server side attribute validation needs to know about event names,
21+
// so we have to inject the event system. We only need it in development.
22+
// TODO: this is gross. Find another way.
23+
require('ReactDOMClientInjection');
24+
}
1925

2026
var ReactDOMServerStack = {
2127
renderToString: ReactServerRendering.renderToString,

0 commit comments

Comments
 (0)