Skip to content

Commit d799324

Browse files
noahlemennoahlemen
committed
cleanup enableProfilerNestedUpdateScheduledHook feature flag (#28509)
## Summary Looks like this was added years ago for instrumentation at meta that never ended up rolling out. Should be safe to clean up. ## How did you test this change? `yarn test` DiffTrain build for commit 0d1ae5d.
1 parent 15a88b6 commit d799324

9 files changed

Lines changed: 22 additions & 22 deletions

File tree

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<db79d0fa61da74ae92c8d9795516873a>>
10+
* @generated SignedSource<<5567992397ed27615daacd939e3142d0>>
1111
*/
1212

1313
"use strict";
@@ -21581,7 +21581,7 @@ if (__DEV__) {
2158121581
}
2158221582
var hasUncaughtError = false;
2158321583
var firstUncaughtError = null;
21584-
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
21584+
var legacyErrorBoundariesThatAlreadyFailed = null;
2158521585
var rootDoesHavePassiveEffects = false;
2158621586
var rootWithPendingPassiveEffects = null;
2158721587
var pendingPassiveEffectsLanes = NoLanes;
@@ -23594,7 +23594,7 @@ if (__DEV__) {
2359423594
// Mark the current commit time to be shared by all Profilers in this
2359523595
// batch. This enables them to be grouped later.
2359623596
recordCommitTime();
23597-
}
23597+
} // The next phase is the mutation phase, where we mutate the host tree.
2359823598

2359923599
commitMutationEffects(root, finishedWork);
2360023600
// the mutation phase, so that the previous tree is still current during
@@ -25677,7 +25677,7 @@ if (__DEV__) {
2567725677
return root;
2567825678
}
2567925679

25680-
var ReactVersion = "18.3.0-canary-dfaed5582-20240311";
25680+
var ReactVersion = "18.3.0-canary-0d1ae5d75-20240311";
2568125681

2568225682
// Might add PROFILE later.
2568325683

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9147,7 +9147,7 @@ var devToolsConfig$jscomp$inline_1016 = {
91479147
throw Error("TestRenderer does not support findFiberByHostInstance()");
91489148
},
91499149
bundleType: 0,
9150-
version: "18.3.0-canary-dfaed5582-20240311",
9150+
version: "18.3.0-canary-0d1ae5d75-20240311",
91519151
rendererPackageName: "react-test-renderer"
91529152
};
91539153
var internals$jscomp$inline_1194 = {
@@ -9178,7 +9178,7 @@ var internals$jscomp$inline_1194 = {
91789178
scheduleRoot: null,
91799179
setRefreshHandler: null,
91809180
getCurrentFiber: null,
9181-
reconcilerVersion: "18.3.0-canary-dfaed5582-20240311"
9181+
reconcilerVersion: "18.3.0-canary-0d1ae5d75-20240311"
91829182
};
91839183
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91849184
var hook$jscomp$inline_1195 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9575,7 +9575,7 @@ var devToolsConfig$jscomp$inline_1058 = {
95759575
throw Error("TestRenderer does not support findFiberByHostInstance()");
95769576
},
95779577
bundleType: 0,
9578-
version: "18.3.0-canary-dfaed5582-20240311",
9578+
version: "18.3.0-canary-0d1ae5d75-20240311",
95799579
rendererPackageName: "react-test-renderer"
95809580
};
95819581
var internals$jscomp$inline_1235 = {
@@ -9606,7 +9606,7 @@ var internals$jscomp$inline_1235 = {
96069606
scheduleRoot: null,
96079607
setRefreshHandler: null,
96089608
getCurrentFiber: null,
9609-
reconcilerVersion: "18.3.0-canary-dfaed5582-20240311"
9609+
reconcilerVersion: "18.3.0-canary-0d1ae5d75-20240311"
96109610
};
96119611
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96129612
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if (__DEV__) {
2626
}
2727
var dynamicFlags = require("ReactNativeInternalFeatureFlags");
2828

29-
var ReactVersion = "18.3.0-canary-dfaed5582-20240311";
29+
var ReactVersion = "18.3.0-canary-0d1ae5d75-20240311";
3030

3131
// ATTENTION
3232
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,4 +628,4 @@ exports.useSyncExternalStore = function (
628628
exports.useTransition = function () {
629629
return ReactCurrentDispatcher.current.useTransition();
630630
};
631-
exports.version = "18.3.0-canary-dfaed5582-20240311";
631+
exports.version = "18.3.0-canary-0d1ae5d75-20240311";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ exports.useSyncExternalStore = function (
624624
exports.useTransition = function () {
625625
return ReactCurrentDispatcher.current.useTransition();
626626
};
627-
exports.version = "18.3.0-canary-dfaed5582-20240311";
627+
exports.version = "18.3.0-canary-0d1ae5d75-20240311";
628628
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
629629
"function" ===
630630
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
dfaed5582550f11b27aae967a8e7084202dd2d90
1+
0d1ae5d753044fae99bc37a7815aa947447de3f8

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9c2330dcbae0932d46415008abf39f83>>
10+
* @generated SignedSource<<2cdd07c219807a7aa7c60e7298609102>>
1111
*/
1212

1313
"use strict";
@@ -25662,7 +25662,7 @@ to return true:wantsResponderID| |
2566225662
}
2566325663
var hasUncaughtError = false;
2566425664
var firstUncaughtError = null;
25665-
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
25665+
var legacyErrorBoundariesThatAlreadyFailed = null;
2566625666
var rootDoesHavePassiveEffects = false;
2566725667
var rootWithPendingPassiveEffects = null;
2566825668
var pendingPassiveEffectsLanes = NoLanes;
@@ -27804,7 +27804,7 @@ to return true:wantsResponderID| |
2780427804
// Mark the current commit time to be shared by all Profilers in this
2780527805
// batch. This enables them to be grouped later.
2780627806
recordCommitTime();
27807-
}
27807+
} // The next phase is the mutation phase, where we mutate the host tree.
2780827808

2780927809
commitMutationEffects(root, finishedWork, lanes);
2781027810
// the mutation phase, so that the previous tree is still current during
@@ -27821,7 +27821,7 @@ to return true:wantsResponderID| |
2782127821

2782227822
{
2782327823
markLayoutEffectsStopped();
27824-
}
27824+
} // Tell Scheduler to yield at the end of the frame, so the browser has an
2782527825
// opportunity to paint.
2782627826

2782727827
requestPaint();
@@ -30184,7 +30184,7 @@ to return true:wantsResponderID| |
3018430184
return root;
3018530185
}
3018630186

30187-
var ReactVersion = "18.3.0-canary-d10dabcc";
30187+
var ReactVersion = "18.3.0-canary-625ba3e2";
3018830188

3018930189
function createPortal$1(
3019030190
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e3846f3f34dc54e4ddf149e8629d7fd3>>
10+
* @generated SignedSource<<d8ff468ccc27dd6a134e0a8f6e70d25e>>
1111
*/
1212

1313
"use strict";
@@ -26102,7 +26102,7 @@ to return true:wantsResponderID| |
2610226102
}
2610326103
var hasUncaughtError = false;
2610426104
var firstUncaughtError = null;
26105-
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
26105+
var legacyErrorBoundariesThatAlreadyFailed = null;
2610626106
var rootDoesHavePassiveEffects = false;
2610726107
var rootWithPendingPassiveEffects = null;
2610826108
var pendingPassiveEffectsLanes = NoLanes;
@@ -28244,7 +28244,7 @@ to return true:wantsResponderID| |
2824428244
// Mark the current commit time to be shared by all Profilers in this
2824528245
// batch. This enables them to be grouped later.
2824628246
recordCommitTime();
28247-
}
28247+
} // The next phase is the mutation phase, where we mutate the host tree.
2824828248

2824928249
commitMutationEffects(root, finishedWork, lanes);
2825028250
// the mutation phase, so that the previous tree is still current during
@@ -28261,7 +28261,7 @@ to return true:wantsResponderID| |
2826128261

2826228262
{
2826328263
markLayoutEffectsStopped();
28264-
}
28264+
} // Tell Scheduler to yield at the end of the frame, so the browser has an
2826528265
// opportunity to paint.
2826628266

2826728267
requestPaint();
@@ -30624,7 +30624,7 @@ to return true:wantsResponderID| |
3062430624
return root;
3062530625
}
3062630626

30627-
var ReactVersion = "18.3.0-canary-e7e333a2";
30627+
var ReactVersion = "18.3.0-canary-691a723b";
3062830628

3062930629
function createPortal$1(
3063030630
children,

0 commit comments

Comments
 (0)