Merge pull request #979 from flippercloud/worktree-wild-watching-cloud

Add config to disable the Fully Enable button

Author: jnunemaker

CLAUDE.md

@@ -85,3 +85,5 @@ For outbound HTTP requests, use `Flipper::Adapters::Http::Client` instead of raw
 ### Testing
 
 Uses both RSpec (currently preferred for new tests) and Minitest. Shared adapter specs ensure consistency across all storage backends. Extensive testing across multiple Rails versions (5.0-8.0).
+
+`Flipper.configuration` is reset to nil before each spec (in `spec/spec_helper.rb`), but `Flipper::UI.configuration` is **not** globally reset. When modifying UI config in tests, set the value in `before` and reset it in `after` to match the existing pattern throughout the spec suite.

lib/flipper/ui/actions/boolean_gate.rb

@@ -16,6 +16,10 @@ def post
           @feature = Decorators::Feature.new(feature)
 
           if params['action'] == 'Enable'
+            if Flipper::UI.configuration.disable_fully_enable
+              status 403
+              halt view_response(:disable_fully_enable)
+            end
             feature.enable
           else
             feature.disable

lib/flipper/ui/configuration.rb

@@ -77,6 +77,20 @@ class Configuration
       # Default is false.
       attr_accessor :confirm_disable
 
+      # Public: Set to disable the Fully Enable button in the UI, preventing
+      # users from fully enabling features via the web interface. Set to true
+      # for a default message, or a string for a custom message. Defaults to nil.
+      #
+      # Note: This only affects the UI. If flipper-api is mounted, full enable
+      # is still possible via the API.
+      #
+      # Examples:
+      #
+      #   config.disable_fully_enable = true
+      #   config.disable_fully_enable = "Use deploy pipeline instead."
+      #
+      attr_accessor :disable_fully_enable
+
       VALID_BANNER_CLASS_VALUES = %w(
         danger
         dark
@@ -90,6 +104,7 @@ class Configuration
 
       DEFAULT_DESCRIPTIONS_SOURCE = ->(_keys) { {} }
       DEFAULT_ACTOR_NAMES_SOURCE = ->(_keys) { {} }
+      DEFAULT_DISABLE_FULLY_ENABLE_MESSAGE = "Fully enabling features via the UI is disabled."
 
       def initialize
         @delete = Option.new("Danger Zone", "Deleting a feature removes it from the list of features and disables it for everyone.")
@@ -106,6 +121,7 @@ def initialize
         @actors_separator = ','
         @confirm_fully_enable = false
         @confirm_disable = true
+        @disable_fully_enable = nil
         @read_only = false
         @nav_items = [
           { title: "Features", href: "features" },
@@ -121,6 +137,14 @@ def show_feature_description_in_list?
         using_descriptions? && @show_feature_description_in_list
       end
 
+      def disable_fully_enable_message
+        if @disable_fully_enable.is_a?(String)
+          @disable_fully_enable
+        else
+          DEFAULT_DISABLE_FULLY_ENABLE_MESSAGE
+        end
+      end
+
       def banner_class=(value)
         unless VALID_BANNER_CLASS_VALUES.include?(value)
           raise InvalidConfigurationValue, "The banner_class provided '#{value}' is " \

lib/flipper/ui/views/disable_fully_enable.erb

@@ -0,0 +1,3 @@
+<div class="alert alert-danger">
+  <%= Flipper::UI.configuration.disable_fully_enable_message %>
+</div>

lib/flipper/ui/views/feature.erb

@@ -255,16 +255,24 @@
             <div class="row">
               <% unless @feature.boolean_value %>
                 <div class="col d-grid">
-                  <button type="submit" name="action" value="Enable" class="btn btn-outline-success"
-                    <% if Flipper::UI.configuration.confirm_fully_enable %>
-                      data-confirmation-prompt="Are you sure you want to fully enable this feature for everyone? Please enter the name of the feature to confirm it: <%= feature_name %>"
-                      data-confirmation-text="<%= feature_name %>"
-                    <% end %>
-                  >
-                    <span class="d-block" data-bs-toggle="tooltip" title="Enable for everyone">
-                      Fully Enable
+                  <% if Flipper::UI.configuration.disable_fully_enable %>
+                    <span class="d-inline-block" tabindex="0" data-bs-toggle="tooltip" title="<%= Flipper::UI.configuration.disable_fully_enable_message %>">
+                      <button type="submit" name="action" value="Enable" class="btn btn-outline-success w-100" disabled style="pointer-events: none;">
+                        Fully Enable
+                      </button>
                     </span>
-                  </button>
+                  <% else %>
+                    <button type="submit" name="action" value="Enable" class="btn btn-outline-success"
+                      <% if Flipper::UI.configuration.confirm_fully_enable %>
+                        data-confirmation-prompt="Are you sure you want to fully enable this feature for everyone? Please enter the name of the feature to confirm it: <%= feature_name %>"
+                        data-confirmation-text="<%= feature_name %>"
+                      <% end %>
+                    >
+                      <span class="d-block" data-bs-toggle="tooltip" title="Enable for everyone">
+                        Fully Enable
+                      </span>
+                    </button>
+                  <% end %>
                 </div>
               <% end %>
 

spec/flipper/ui/actions/boolean_gate_spec.rb

@@ -64,5 +64,76 @@
         expect(last_response.headers['location']).to eq('/features/search')
       end
     end
+
+    context 'when disable_fully_enable is false' do
+      before { Flipper::UI.configuration.disable_fully_enable = false }
+      after { Flipper::UI.configuration.disable_fully_enable = nil }
+
+      it 'allows enabling the feature' do
+        flipper.disable :search
+        post 'features/search/boolean',
+             { 'action' => 'Enable', 'authenticity_token' => token },
+             'rack.session' => session
+        expect(flipper.enabled?(:search)).to be(true)
+      end
+    end
+
+    context 'when disable_fully_enable is true' do
+      before { Flipper::UI.configuration.disable_fully_enable = true }
+      after { Flipper::UI.configuration.disable_fully_enable = nil }
+
+      context 'with enable' do
+        before do
+          flipper.disable :search
+          post 'features/search/boolean',
+               { 'action' => 'Enable', 'authenticity_token' => token },
+               'rack.session' => session
+        end
+
+        it 'does not enable the feature' do
+          expect(flipper.enabled?(:search)).to be(false)
+        end
+
+        it 'returns 403 status' do
+          expect(last_response.status).to be(403)
+        end
+
+        it 'renders the default disabled message' do
+          expect(last_response.body).to include('Fully enabling features via the UI is disabled.')
+        end
+      end
+
+      context 'with disable' do
+        before do
+          flipper.enable :search
+          post 'features/search/boolean',
+               { 'action' => 'Disable', 'authenticity_token' => token },
+               'rack.session' => session
+        end
+
+        it 'still allows disabling the feature' do
+          expect(flipper.enabled?(:search)).to be(false)
+        end
+
+        it 'redirects back to feature' do
+          expect(last_response.status).to be(302)
+          expect(last_response.headers['location']).to eq('/features/search')
+        end
+      end
+    end
+
+    context 'when disable_fully_enable is a custom message' do
+      before { Flipper::UI.configuration.disable_fully_enable = "Use deploy pipeline instead." }
+      after { Flipper::UI.configuration.disable_fully_enable = nil }
+
+      it 'renders the custom message on 403' do
+        flipper.disable :search
+        post 'features/search/boolean',
+             { 'action' => 'Enable', 'authenticity_token' => token },
+             'rack.session' => session
+        expect(last_response.status).to be(403)
+        expect(last_response.body).to include('Use deploy pipeline instead.')
+      end
+    end
   end
 end

spec/flipper/ui/actions/feature_spec.rb

@@ -125,6 +125,32 @@
       end
     end
 
+    context "when disable_fully_enable is true" do
+      before { Flipper::UI.configuration.disable_fully_enable = true }
+      after { Flipper::UI.configuration.disable_fully_enable = nil }
+
+      it 'renders the Fully Enable button as disabled' do
+        get '/features/search'
+        expect(last_response.body).to include('Fully Enable')
+        expect(last_response.body).to match(/disabled\s*>/)
+      end
+
+      it 'shows the default disabled tooltip' do
+        get '/features/search'
+        expect(last_response.body).to include('Fully enabling features via the UI is disabled.')
+      end
+    end
+
+    context "when disable_fully_enable is a custom message" do
+      before { Flipper::UI.configuration.disable_fully_enable = "Use deploy pipeline instead." }
+      after { Flipper::UI.configuration.disable_fully_enable = nil }
+
+      it 'shows custom disabled tooltip' do
+        get '/features/search'
+        expect(last_response.body).to include('Use deploy pipeline instead.')
+      end
+    end
+
     context 'custom actor names' do
       before do
         actor = Flipper::Actor.new('some_actor_name')

spec/flipper/ui/configuration_spec.rb

@@ -146,6 +146,39 @@
     end
   end
 
+  describe "#disable_fully_enable" do
+    it "defaults to nil" do
+      expect(configuration.disable_fully_enable).to be_nil
+    end
+
+    it "can be set to true" do
+      configuration.disable_fully_enable = true
+      expect(configuration.disable_fully_enable).to eq(true)
+    end
+
+    it "can be set to false" do
+      configuration.disable_fully_enable = false
+      expect(configuration.disable_fully_enable).to eq(false)
+    end
+
+    it "can be set to a custom message" do
+      configuration.disable_fully_enable = "Use deploy pipeline instead."
+      expect(configuration.disable_fully_enable).to eq("Use deploy pipeline instead.")
+    end
+  end
+
+  describe "#disable_fully_enable_message" do
+    it "returns default message when set to true" do
+      configuration.disable_fully_enable = true
+      expect(configuration.disable_fully_enable_message).to eq("Fully enabling features via the UI is disabled.")
+    end
+
+    it "returns custom message when set to a string" do
+      configuration.disable_fully_enable = "Use deploy pipeline instead."
+      expect(configuration.disable_fully_enable_message).to eq("Use deploy pipeline instead.")
+    end
+  end
+
   describe "#show_feature_description_in_list" do
     it "has default value" do
       expect(configuration.show_feature_description_in_list).to eq(false)