more tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

Author: pingsutw

go/tasks/plugins/array/k8s/subtask_test.go

@@ -0,0 +1,40 @@
+package k8s
+
+import (
+	"testing"
+
+	"github.com/flyteorg/flyteplugins/go/tasks/pluginmachinery/flytek8s"
+	"github.com/flyteorg/flyteplugins/go/tasks/pluginmachinery/flytek8s/config"
+	"gotest.tools/assert"
+	v1 "k8s.io/api/core/v1"
+)
+
+func TestGetTaskContainerTask(t *testing.T) {
+	pod := &v1.Pod{
+		Spec: v1.PodSpec{
+			Containers: []v1.Container{
+				{
+					Name: "PrimaryContainer",
+				},
+			},
+		},
+	}
+	index, err := getTaskContainerIndex(pod)
+	assert.NilError(t, err)
+	assert.Equal(t, index, 0)
+
+	pod.Spec.Containers = append(pod.Spec.Containers, v1.Container{Name: config.GetK8sPluginConfig().CoPilot.NamePrefix + flytek8s.Sidecar})
+	index, err = getTaskContainerIndex(pod)
+	assert.NilError(t, err)
+	assert.Equal(t, index, 0)
+
+	pod.Annotations = map[string]string{flytek8s.PrimaryContainerKey: "PrimaryContainer"}
+	index, err = getTaskContainerIndex(pod)
+	assert.NilError(t, err)
+	assert.Equal(t, index, 0)
+
+	pod.Spec.Containers[0].Name = "SecondaryContainer"
+	_, err = getTaskContainerIndex(pod)
+	assert.ErrorContains(t, err, "Couldn't find any container matching the primary container")
+
+}

go/tasks/plugins/k8s/pod/plugin.go

@@ -146,12 +146,10 @@ func (p plugin) GetTaskPhase(ctx context.Context, pluginContext k8s.PluginContex
 
 func (plugin) GetTaskPhaseWithLogs(ctx context.Context, pluginContext k8s.PluginContext, r client.Object, logPlugin tasklog.Plugin, logSuffix string) (pluginsCore.PhaseInfo, error) {
 	pluginState := k8s.PluginState{}
-	var err error
-	//_, err := pluginContext.PluginStateReader().Get(&pluginState)
-	//if err != nil {
-	//	logger.Errorf(ctx, "kevin test [%v]", err)
-	//	return pluginsCore.PhaseInfoUndefined, err
-	//}
+	_, err := pluginContext.PluginStateReader().Get(&pluginState)
+	if err != nil {
+		return pluginsCore.PhaseInfoUndefined, err
+	}
 
 	pod := r.(*v1.Pod)