fix(deps): bump typescript from 5.9.3 to 6.0.2#234
Conversation
eac3b5d to
963733d
Compare
963733d to
e93f3ae
Compare
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 6.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.2) --- updated-dependencies: - dependency-name: typescript dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
e93f3ae to
aa10e3f
Compare
|
@copilot the upgrade to Typescript 6 is failing the CI build and checks. |
Agent-Logs-Url: https://github.com/forwardsoftware/react-auth/sessions/8f5f422d-6211-4173-aa5f-08d0494ecae3 Co-authored-by: panz3r <1754457+panz3r@users.noreply.github.com>
Head branch was pushed to by a user without write access
Agent-Logs-Url: https://github.com/forwardsoftware/react-auth/sessions/8f5f422d-6211-4173-aa5f-08d0494ecae3 Co-authored-by: panz3r <1754457+panz3r@users.noreply.github.com>
Fixed in commit
Builds and all 58 tests pass locally with TypeScript 6.0.2. |
* fix(deps): bump typescript from 5.9.3 to 6.0.2 Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 6.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.2) --- updated-dependencies: - dependency-name: typescript dependency-version: 6.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * initial plan Agent-Logs-Url: https://github.com/forwardsoftware/react-auth/sessions/8f5f422d-6211-4173-aa5f-08d0494ecae3 Co-authored-by: panz3r <1754457+panz3r@users.noreply.github.com> * fix: update tsconfig moduleResolution for TypeScript 6.0 compatibility Agent-Logs-Url: https://github.com/forwardsoftware/react-auth/sessions/8f5f422d-6211-4173-aa5f-08d0494ecae3 Co-authored-by: panz3r <1754457+panz3r@users.noreply.github.com> * chore: rebuild lock-file * chore: update `packageManager` version to `pnpm@10.33.0` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: panz3r <1754457+panz3r@users.noreply.github.com>
Bumps typescript from 5.9.3 to 6.0.2 and includes the required configuration changes to support the upgrade.
Affected Package(s)
@forward-software/react-auth(lib)@forward-software/react-auth-google(packages/google-signin)Related Issue(s)
Motivation
TypeScript 6.0 deprecated the
node/node10module resolution strategy and made it a hard error (TS5107). Additionally, TypeScript 6.0 tightened lib defaults, surfacing a previously hidden type error in the google-signin package whereString.prototype.padEnd(an ES2017 method) was used but not included in the default ES6 lib.Description of Changes
lib/tsconfig.json: Changed"moduleResolution": "node"to"moduleResolution": "bundler"to resolve TS5107 deprecation error in TypeScript 6.0packages/google-signin/tsconfig.json: Changed"moduleResolution": "node"to"moduleResolution": "bundler"and added"lib": ["ES2017", "DOM"]to explicitly include ES2017 string methods (padEnd) and DOM APIs (atob) that are used inbase64UrlDecodeBreaking Changes
None
How to Test
Vitest) and build steps pass successfully on this PR.pnpm installto install dependencies.pnpm --filter <affected-package> testto run tests for the affected package.pnpm --filter <affected-package> buildto verify the build succeeds.pnpm --filter <affected-package> lintto check for linting errors.Checklist
Notes for Reviewers
Two TypeScript 6.0 breaking changes required fixes:
TS5107 — deprecated
moduleResolution: node: TypeScript 6.0 deprecatednode(an alias fornode10) and now raises it as a hard error. Updated both packages to use"moduleResolution": "bundler", which is the appropriate modern choice for React libraries consumed by bundlers.TS2550 —
padEndnot in ES6 lib: TypeScript 6.0 tightened lib defaults, surfacing thatString.prototype.padEndis an ES2017 API not included in the default ES6 lib. Explicitly specifying"lib": ["ES2017", "DOM"]in the google-signin tsconfig resolves this.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.