Skip to content

Commit 1038a52

Browse files
committed
Make sure getters start with the get prefix
1 parent bfb875e commit 1038a52

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

google-cloud-core/src/main/java/com/google/cloud/testing/BaseEmulatorHelper.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ protected BaseEmulatorHelper(String emulator, int port, String projectId) {
7373
* Returns the emulator runners supported by this emulator. Runners are evaluated in order, the
7474
* first available runner is selected and executed
7575
*/
76-
protected abstract List<EmulatorRunner> emulatorRunners();
76+
protected abstract List<EmulatorRunner> getEmulatorRunners();
7777

7878
/**
7979
* Returns a logger.
@@ -86,7 +86,7 @@ protected BaseEmulatorHelper(String emulator, int port, String projectId) {
8686
*/
8787
protected final void startProcess(String blockUntilOutput)
8888
throws IOException, InterruptedException {
89-
for (EmulatorRunner runner : emulatorRunners()) {
89+
for (EmulatorRunner runner : getEmulatorRunners()) {
9090
// Iterate through all emulator runners until find first available runner.
9191
if (runner.isAvailable()) {
9292
activeRunner = runner;
@@ -262,11 +262,11 @@ private boolean isGcloudInstalled() {
262262
}
263263

264264
private boolean isEmulatorUpToDate() throws IOException, InterruptedException {
265-
Version currentVersion = installedEmulatorVersion(versionPrefix);
265+
Version currentVersion = getInstalledEmulatorVersion(versionPrefix);
266266
return currentVersion != null && currentVersion.compareTo(minVersion) >= 0;
267267
}
268268

269-
private Version installedEmulatorVersion(String versionPrefix)
269+
private Version getInstalledEmulatorVersion(String versionPrefix)
270270
throws IOException, InterruptedException {
271271
Process process =
272272
CommandWrapper.create()

google-cloud-core/src/test/java/com/google/cloud/testing/BaseEmulatorHelperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ private TestEmulatorHelper(List<EmulatorRunner> runners, String blockUntil) {
4646
}
4747

4848
@Override
49-
protected List<EmulatorRunner> emulatorRunners() {
49+
protected List<EmulatorRunner> getEmulatorRunners() {
5050
return runners;
5151
}
5252

google-cloud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private LocalDatastoreHelper(double consistency) {
107107
}
108108

109109
@Override
110-
protected List<EmulatorRunner> emulatorRunners() {
110+
protected List<EmulatorRunner> getEmulatorRunners() {
111111
return emulatorRunners;
112112
}
113113

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/testing/LocalPubSubHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private LocalPubSubHelper() {
8383
}
8484

8585
@Override
86-
protected List<EmulatorRunner> emulatorRunners() {
86+
protected List<EmulatorRunner> getEmulatorRunners() {
8787
return emulatorRunners;
8888
}
8989

0 commit comments

Comments
 (0)