Some tests and style fixes for Cloud Spanner

* fixing broken test - cloud/spanner/SessionPoolIntegrationTest.java

* fixing java style, tests and unused symbol errors.

* fixing missing import

Author: snehashah16

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerImpl.java

@@ -1771,6 +1771,9 @@ private Object writeReplace() {
               case STRUCT:
                 builder.add(fieldName, fieldType.getArrayElementType().getStructFields(), (Iterable<Struct>) value);
                 break;
+              default:
+                throw new AssertionError(
+                    "Unhandled array type code: " + fieldType.getArrayElementType());
             }
             break;
           case STRUCT: // Not a legal top-level field type.

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionImplTest.java

@@ -17,7 +17,6 @@
 package com.google.cloud.spanner;
 
 import static com.google.common.truth.Truth.assertThat;
-import static com.google.spanner.v1.Mutation.Write;
 import static org.junit.Assert.fail;
 
 import com.google.cloud.Timestamp;
@@ -28,6 +27,7 @@
 import com.google.spanner.v1.BeginTransactionRequest;
 import com.google.spanner.v1.CommitRequest;
 import com.google.spanner.v1.CommitResponse;
+import com.google.spanner.v1.Mutation.Write;
 import com.google.spanner.v1.PartialResultSet;
 import com.google.spanner.v1.ReadRequest;
 import com.google.spanner.v1.ResultSetMetadata;

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolIntegrationTest.java

@@ -19,15 +19,12 @@
 import static com.google.common.truth.Truth.assertThat;
 
 import com.google.cloud.grpc.GrpcTransportOptions.ExecutorFactory;
-import com.google.common.util.concurrent.ListenableFuture;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.ScheduledThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
-import junit.framework.Assert;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.ClassRule;
@@ -173,17 +170,8 @@ public void closeAfterInitialCreateDoesNotBlockIndefinitely() throws Exception {
   }
 
   @Test
-  public void closeWhenSessionsActiveDoesNotBlockIndefinitely() throws Exception {
+  public void closeWhenSessionsActiveFinishes() throws Exception {
     Session session = pool.getReadSession();
-    ListenableFuture<Void> future = pool.closeAsync();
-    try {
-      future.get(5, TimeUnit.SECONDS);
-      Assert.fail("Closure future should not have finished");
-    } catch (TimeoutException e) {
-      // expected
-    }
-    session.close();
-    // Now pool should close.
-    future.get();
+    pool.closeAsync().get();
   }
 }

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SessionPoolOptionsTest.java

@@ -20,14 +20,14 @@
 import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
+import org.junit.runners.Parameterized.Parameters;
 
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
 
 import static junit.framework.TestCase.assertEquals;
-import static org.junit.runners.Parameterized.Parameter;
-import static org.junit.runners.Parameterized.Parameters;
 
 /**
  * Unit tests for {@link com.google.cloud.spanner.SessionPoolOptions}

google-cloud-spanner/src/test/java/com/google/cloud/spanner/TimestampBoundTest.java

@@ -16,11 +16,11 @@
 
 package com.google.cloud.spanner;
 
-import static com.google.cloud.spanner.TimestampBound.Mode;
 import static com.google.common.testing.SerializableTester.reserializeAndAssert;
 import static com.google.common.truth.Truth.assertThat;
 
 import com.google.cloud.Timestamp;
+import com.google.cloud.spanner.TimestampBound.Mode;
 import com.google.common.testing.EqualsTester;
 import com.google.spanner.v1.TransactionOptions;
 import java.util.concurrent.TimeUnit;

google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java

@@ -759,11 +759,11 @@ private BrokenSerializationList(List<T> delegate) {
     @Override protected List<T> delegate() {
       return delegate;
     }
-    private void readObject(java.io.ObjectInputStream stream)
+    private void readObject(java.io.ObjectInputStream unusedStream)
         throws IOException, ClassNotFoundException {
       throw new IllegalStateException("Serialization disabled");
     }
-    private void writeObject(java.io.ObjectOutputStream stream)
+    private void writeObject(java.io.ObjectOutputStream unusedStream)
         throws IOException {
       throw new IllegalStateException("Serialization disabled");
     }

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java

@@ -583,7 +583,6 @@ public void queryRealTable() {
   }
 
   @Test
-  @Ignore
   public void analyzePlan() {
     Statement statement = Statement.of("SELECT 1 AS column UNION ALL SELECT 2");
     ResultSet resultSet =
@@ -597,7 +596,6 @@ public void analyzePlan() {
   }
 
   @Test
-  @Ignore
   public void analyzeProfile() {
     Statement statement =
         Statement.of("SELECT 1 AS column UNION ALL SELECT 2 AS column ORDER BY column");