Skip to content

Commit f6b93fa

Browse files
committed
Fix Spanner javadoc errors
1 parent 8c505fc commit f6b93fa

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

google-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,9 +288,10 @@ public interface DatabaseClient {
288288
* statements, such as an OLTP workload, should prefer using {@link
289289
* TransactionContext#executeUpdate(Statement)} with {@link #readWriteTransaction()}.
290290
*
291+
* <p>That said, Partitioned DML is not a drop-in replacement for standard DML used in {@link
292+
* #readWriteTransaction()}.</p>
293+
*
291294
* <ul>
292-
* That said, Partitioned DML is not a drop-in replacement for standard DML used in {@link
293-
* #readWriteTransaction()}.
294295
* <li>The DML statement must be fully-partitionable. Specifically, the statement must be
295296
* expressible as the union of many statements which each access only a single row of the
296297
* table.
@@ -311,6 +312,7 @@ public interface DatabaseClient {
311312
* due to schema constraints), then the operation is stopped at that point and an error is
312313
* returned. It is possible that at this point, some partitions have been committed (or even
313314
* committed multiple times), and other partitions have not been run at all.
315+
* </ul>
314316
*
315317
* <p>Given the above, Partitioned DML is good fit for large, database-wide, operations that are
316318
* idempotent, such as deleting old rows from a very large table.

google-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/ResultSet.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.cloud.spanner;
1818

19+
import com.google.cloud.spanner.Options.QueryOption;
1920
import com.google.spanner.v1.ResultSetStats;
2021
import javax.annotation.Nullable;
2122

@@ -65,7 +66,7 @@ public interface ResultSet extends AutoCloseable, StructReader {
6566
* Returns the {@link ResultSetStats} for the query only if the query was executed in either the
6667
* {@code PLAN} or the {@code PROFILE} mode via the {@link ReadContext#analyzeQuery(Statement,
6768
* com.google.cloud.spanner.ReadContext.QueryAnalyzeMode)} method or for DML statements in
68-
* {@link ReadContext#executeQuery(Statement, QueryOption)}. Attempts to call this method on
69+
* {@link ReadContext#executeQuery(Statement, QueryOption...)}. Attempts to call this method on
6970
* a {@code ResultSet} not obtained from {@code analyzeQuery} or {@code executeQuery} will return
7071
* a {@code null} {@code ResultSetStats}. This method must be called after {@link #next()} has
7172
* returned @{code false}. Calling it before that will result in {@code null}

0 commit comments

Comments
 (0)