Minor optimization of recursive_field_types (#347)

Author: software-dov

packages/gapic-generator/gapic/cli/generate.py

@@ -37,7 +37,6 @@ def generate(
         request: typing.BinaryIO,
         output: typing.BinaryIO) -> None:
     """Generate a full API client description."""
-
     # Load the protobuf CodeGeneratorRequest.
     req = plugin_pb2.CodeGeneratorRequest.FromString(request.read())
 

packages/gapic-generator/gapic/schema/metadata.py

@@ -52,6 +52,19 @@ def __eq__(self, other) -> bool:
         return all([getattr(self, i) == getattr(other, i) for i
                     in ('name', 'module', 'module_path', 'package', 'parent')])
 
+    def __hash__(self):
+        # Do NOT include collisions; they are not relevant.
+        return hash(
+            (
+                self.name,
+                self.module,
+                self.module_path,
+                self.package,
+                self.parent,
+                self.api_naming,
+            )
+        )
+
     def __str__(self) -> str:
         """Return the Python identifier for this type.
 

packages/gapic-generator/gapic/schema/wrappers.py

@@ -221,7 +221,8 @@ def __getattr__(self, name):
         return getattr(self.message_pb, name)
 
     def __hash__(self):
-        return hash(self.name)
+        # Identity is sufficiently unambiguous.
+        return hash(self.ident)
 
     @utils.cached_property
     def field_types(self) -> Sequence[Union['MessageType', 'EnumType']]:
@@ -238,15 +239,16 @@ def recursive_field_types(self) -> Sequence[
         Union['MessageType', 'EnumType']
     ]:
         """Return all composite fields used in this proto's messages."""
-        types: List[Union['MessageType', 'EnumType']] = []
+        types: Set[Union['MessageType', 'EnumType']] = set()
+
         stack = [iter(self.fields.values())]
         while stack:
             fields_iter = stack.pop()
             for field in fields_iter:
                 if field.message and field.type not in types:
                     stack.append(iter(field.message.fields.values()))
                 if not field.is_primitive:
-                    types.append(field.type)
+                    types.add(field.type)
 
         return tuple(types)
 
@@ -391,6 +393,10 @@ class EnumType:
         default_factory=metadata.Metadata,
     )
 
+    def __hash__(self):
+        # Identity is sufficiently unambiguous.
+        return hash(self.ident)
+
     def __getattr__(self, name):
         return getattr(self.enum_pb, name)