refactor: erase strip_backticks() helper (#504)

Author: Ilya Gurov

packages/django-google-spanner/google/cloud/spanner_dbapi/parse_utils.py

@@ -68,15 +68,6 @@ def classify_stmt(sql):
 )
 
 
-def strip_backticks(name):
-    """
-    Strip backticks off of quoted names For example, '`no`' (a Spanner reserved
-    word) becomes 'no'.
-    """
-    has_quotes = name.startswith("`") and name.endswith("`")
-    return name[1:-1] if has_quotes else name
-
-
 def parse_insert(insert_sql, params):
     """
     Parse an INSERT statement an generate a list of tuples of the form:
@@ -169,10 +160,7 @@ def parse_insert(insert_sql, params):
     if values.homogenous():
         # Case c)
 
-        columns = [
-            strip_backticks(mi.strip())
-            for mi in match.group("columns").split(",")
-        ]
+        columns = [mi.strip(" `") for mi in match.group("columns").split(",")]
         sql_params_list = []
         insert_sql_preamble = "INSERT INTO %s (%s) VALUES %s" % (
             match.group("table_name"),

packages/django-google-spanner/tests/spanner_dbapi/test_parse_utils.py

@@ -22,7 +22,6 @@
     parse_insert,
     rows_for_insert_or_update,
     sql_pyformat_args_to_spanner,
-    strip_backticks,
 )
 from google.cloud.spanner_dbapi.utils import backtick_unicode
 
@@ -491,13 +490,6 @@ def test_escape_name(self):
                 got = escape_name(name)
                 self.assertEqual(got, want)
 
-    def test_strip_backticks(self):
-        cases = [("foo", "foo"), ("`foo`", "foo")]
-        for name, want in cases:
-            with self.subTest(name=name):
-                got = strip_backticks(name)
-                self.assertEqual(got, want)
-
     def test_backtick_unicode(self):
         cases = [
             ("SELECT (1) as foo WHERE 1=1", "SELECT (1) as foo WHERE 1=1"),