Commit 78d6d63
authored
fix: from_service_account constructors for async clients (#779)
Currently, creating async clients with constructor works fine:
from google.cloud import vision
client = vision.ImageAnnotatorAsyncClient()
print(type(client))
prints: <class 'google.cloud.vision_v1.services.image_annotator.async_client.ImageAnnotatorAsyncClient'>
Using from_service_account_* methods on the other hand return sync client:
client = vision.ImageAnnotatorAsyncClient.from_service_account_file("service_account.json")
print(type(client))
This gives <class 'google.cloud.vision_v1.services.image_annotator.client.ImageAnnotatorClient'>, which is just a normal synchronous client.
This happens because these functions are linked to sync clients' methods. Now it's fixed to call the same method, but with proper class.1 parent b5f3ee2 commit 78d6d63
2 files changed
Lines changed: 41 additions & 4 deletions
File tree
- packages/gapic-generator/gapic/templates
- %namespace/%name_%version/%sub/services/%service
- tests/unit/gapic/%name_%version/%sub
Lines changed: 30 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
53 | 81 | | |
54 | 82 | | |
55 | 83 | | |
| |||
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
81 | 87 | | |
82 | 88 | | |
83 | 89 | | |
84 | 90 | | |
85 | | - | |
| 91 | + | |
86 | 92 | | |
| 93 | + | |
87 | 94 | | |
88 | 95 | | |
89 | 96 | | |
| |||
100 | 107 | | |
101 | 108 | | |
102 | 109 | | |
| 110 | + | |
103 | 111 | | |
104 | 112 | | |
105 | 113 | | |
| 114 | + | |
106 | 115 | | |
107 | 116 | | |
108 | 117 | | |
| |||
0 commit comments