fix: db.params OpenTelemetry integration issue (#346)

When db.params are not all of the same type OpenTelemetry will log a warning.

Prevent this by stringifying values.

Also adds a  SQLALCHEMY_SPANNER_TRACE_HIDE_QUERY_PARAMETERS env var to prevent logging db.params to OpenTelemetry.

Co-authored-by: Knut Olav Løite <koloite@gmail.com>

Author: gillesleblanc

packages/sqlalchemy-spanner/google/cloud/sqlalchemy_spanner/_opentelemetry_tracing.py

@@ -14,6 +14,9 @@
 
 """Manages OpenTelemetry trace creation and handling"""
 
+import collections
+import os
+
 from contextlib import contextmanager
 
 from google.api_core.exceptions import GoogleAPICallError
@@ -46,6 +49,16 @@ def trace_call(name, extra_attributes=None):
     }
 
     if extra_attributes:
+        if os.environ.get("SQLALCHEMY_SPANNER_TRACE_HIDE_QUERY_PARAMETERS"):
+            extra_attributes.pop("db.params", None)
+
+        # Stringify "db.params" sequence values before sending to OpenTelemetry,
+        # otherwise OpenTelemetry may log a Warning if types differ.
+        if isinstance(extra_attributes, dict):
+            for k, v in extra_attributes.items():
+                if k == "db.params" and isinstance(v, collections.abc.Sequence):
+                    extra_attributes[k] = [str(e) for e in v]
+
         attributes.update(extra_attributes)
 
     with tracer.start_as_current_span(