Harden against empty 'projects.subscriptions.pull' responses.

tseaver · tseaver · commit dd38d6624465 · 2016-04-28T10:40:57.000-04:00
diff --git a/gcloud/pubsub/connection.py b/gcloud/pubsub/connection.py
@@ -416,7 +416,7 @@ def subscription_pull(self, subscription_path, return_immediately=False,
             'maxMessages': max_messages,
         }
         response = conn.api_request(method='POST', path=path, data=data)
-        return response['receivedMessages']
+        return response.get('receivedMessages', ())
 
     def subscription_acknowledge(self, subscription_path, ack_ids):
         """API call:  acknowledge retrieved messages for the subscription.

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ def subscription_pull(self, subscription_path, return_immediately=False,`
`416`	`416`	`'maxMessages': max_messages,`
`417`	`417`	`}`
`418`	`418`	`response = conn.api_request(method='POST', path=path, data=data)`
`419`		`- return response['receivedMessages']`
	`419`	`+ return response.get('receivedMessages', ())`
`420`	`420`
`421`	`421`	`def subscription_acknowledge(self, subscription_path, ack_ids):`
`422`	`422`	`"""API call: acknowledge retrieved messages for the subscription.`