Skip to content

Commit 9b290ad

Browse files
author
Арапов Александр
committed
hardcode-dev#2: Оптимизация подсчёта уникальных браузеров
1 parent 005a463 commit 9b290ad

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

task_1.rb

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
require 'debug'
99
require 'minitest/autorun'
1010

11-
data_file = ENV.fetch('DATA_FILE', 'data5000.txt')
12-
DATA_FILE_PATH = "data/#{data_file}".freeze
11+
DATA_FILE_PATH = "data/#{ENV.fetch('DATA_FILE', 'data40000.txt')}".freeze
1312

1413
class User
1514
attr_reader :attributes, :sessions
@@ -82,13 +81,13 @@ def work(file = DATA_FILE_PATH)
8281
report[:totalUsers] = users.count
8382

8483
# Подсчёт количества уникальных браузеров
85-
uniqueBrowsers = []
84+
unique_browsers = []
8685
sessions.each do |session|
8786
browser = session['browser']
88-
uniqueBrowsers += [browser] if uniqueBrowsers.all? { |b| b != browser }
87+
unique_browsers << browser unless unique_browsers.include?(browser)
8988
end
9089

91-
report['uniqueBrowsersCount'] = uniqueBrowsers.count
90+
report['uniqueBrowsersCount'] = unique_browsers.count
9291

9392
report['totalSessions'] = sessions.count
9493

0 commit comments

Comments
 (0)