Replace lodash with native code

Author: pimterry

module/package.json

@@ -15,15 +15,13 @@
   "license": "AGPL-3.0-or-later",
   "devDependencies": {
     "@types/dedent": "^0.7.0",
-    "@types/lodash": "^4.14.168",
     "typescript": "^5.9.2"
   },
   "dependencies": {
     "@httptoolkit/util": "^0.1.5",
     "@types/node": "*",
     "async-mutex": "^0.2.6",
     "dedent": "^0.7.0",
-    "jose": "^5.2.0",
-    "lodash": "^4.17.21"
+    "jose": "^5.2.0"
   }
 }

module/src/auth.ts

@@ -1,4 +1,3 @@
-import * as _ from 'lodash';
 import { Mutex } from 'async-mutex';
 import { asErrorLike, CustomError } from '@httptoolkit/util';
 
@@ -450,6 +449,13 @@ async function parseBillingData(billingData: UserBillingData | null): Promise<Bi
     };
 }
 
+// Checks all fields except the listed optional ones are non-null/undefined
+function hasAllRequiredFields(obj: Record<string, unknown>, optionalFields: string[]) {
+    return Object.entries(obj)
+        .filter(([key]) => !optionalFields.includes(key))
+        .every(([_, v]) => v != null);
+}
+
 function parseSubscriptionData(rawData: SubscriptionData) {
     const sku = rawData.subscription_sku
         ?? getSKUForPaddleId(rawData.subscription_plan_id);
@@ -472,7 +478,7 @@ function parseSubscriptionData(rawData: SubscriptionData) {
         canManageSubscription: !!rawData.can_manage_subscription
     };
 
-    if (_.some(subscription) && !subscription.plan) {
+    if (Object.values(subscription).some(Boolean) && !subscription.plan) {
         // No plan means no recognized plan, i.e. an unknown id. This should never happen,
         // but error reports suggest it's happened at least once.
         console.warn('Invalid raw subscription data', rawData)
@@ -485,10 +491,7 @@ function parseSubscriptionData(rawData: SubscriptionData) {
         'cancelSubscriptionUrl'
     ];
 
-    const isCompleteSubscriptionData = _.every(
-        _.omit(subscription, ...optionalFields),
-        v => !_.isNil(v) // Not just truthy: canManageSubscription can be false on valid sub
-    );
+    const isCompleteSubscriptionData = hasAllRequiredFields(subscription, optionalFields);
 
     // Use undefined rather than {} or partial data when there's any missing required sub fields
     return isCompleteSubscriptionData

module/src/plans.ts

@@ -1,4 +1,3 @@
-import * as _ from 'lodash';
 import { delay, doWhile } from '@httptoolkit/util';
 import { SKU, SubscriptionPricing } from './types';
 
@@ -44,9 +43,9 @@ async function loadPlanPrices() {
     const productPrices = data.response.products as Array<SubscriptionPricing>;
 
     productPrices.forEach((productPrice) => {
-        const plan = _.find(SubscriptionPlans,
-            { paddleId: productPrice.product_id }
-        ) as SubscriptionPlan | undefined;
+        const plan = Object.values(SubscriptionPlans).find(
+            plan => plan.paddleId === productPrice.product_id
+        );
 
         if (!plan) return;
 
@@ -77,7 +76,7 @@ export async function loadPlanPricesUntilSuccess() {
         ]).then(() => delay(1000)), // Limit the frequency
 
         // While: if any subs didn't successfully get data, try again:
-        () => _.some(SubscriptionPlans, (plan) => !plan.prices),
+        () => Object.values(SubscriptionPlans).some((plan) => !plan.prices),
     );
 
     return SubscriptionPlans;
@@ -87,12 +86,14 @@ function formatPrice(currency: string, price: number) {
     return Number(price).toLocaleString(undefined, {
         style: "currency",
         currency: currency,
-        minimumFractionDigits: _.round(price) === price ? 0 : 2,
+        minimumFractionDigits: Math.round(price) === price ? 0 : 2,
         maximumFractionDigits: 2
     })
 }
 
 export const getPlanByCode = (sku: SKU) => SubscriptionPlans[sku];
 
 export const getSKUForPaddleId = (paddleId: number | undefined) =>
-    _.findKey(SubscriptionPlans, { paddleId: paddleId }) as SKU | undefined;
+    (Object.keys(SubscriptionPlans) as SKU[]).find(sku =>
+        SubscriptionPlans[sku].paddleId === paddleId
+    );