Support ordering_key

Author: rwstauner

ext/bindings/message.cpp

@@ -32,6 +32,8 @@ Message::Message(const std::string& data, Rice::Object arg = Rice::Object()) {
         }
       } else if (key == "partition_key") {
         mb.setPartitionKey(Rice::Object(it->value).to_s().str());
+      } else if (key == "ordering_key") {
+        mb.setOrderingKey(Rice::Object(it->value).to_s().str());
       } else {
         throw Rice::Exception(rb_eArgError, "Unknown keyword argument: %s", key.c_str());
       }
@@ -59,6 +61,10 @@ Rice::String Message::getPartitionKey() {
   return to_ruby(_msg.getPartitionKey());
 }
 
+Rice::String Message::getOrderingKey() {
+  return to_ruby(_msg.getOrderingKey());
+}
+
 }
 
 using namespace Rice;
@@ -77,5 +83,6 @@ void bind_message(Module& module) {
     .define_method("message_id", &pulsar_rb::Message::getMessageId)
     .define_method("properties", &pulsar_rb::Message::getProperties)
     .define_method("partition_key", &pulsar_rb::Message::getPartitionKey)
+    .define_method("ordering_key", &pulsar_rb::Message::getOrderingKey)
     ;
 }

ext/bindings/message.hpp

@@ -28,6 +28,7 @@ namespace pulsar_rb {
     MessageId::ptr getMessageId();
     Rice::Hash getProperties();
     Rice::String getPartitionKey();
+    Rice::String getOrderingKey();
 
     typedef Rice::Data_Object<Message> ptr;
   };

spec/pulsar/message_spec.rb

@@ -82,6 +82,28 @@
       end
     end
 
+    describe "ordering_key" do
+      it "defaults to blank string" do
+        m = described_class.new("payload")
+        expect(m.ordering_key).to eq("")
+      end
+
+      it "accepts ordering key" do
+        m = described_class.new("payload", ordering_key: "foo")
+        expect(m.ordering_key).to eq("foo")
+      end
+
+      it "accepts nil ordering key" do
+        m = described_class.new("payload", ordering_key: nil)
+        expect(m.ordering_key).to eq("")
+      end
+
+      it "stringifies ordering key" do
+        m = described_class.new("payload", ordering_key: ["o"])
+        expect(m.ordering_key).to eq(%(["o"]))
+      end
+    end
+
     describe "errors" do
       it "rejects second arg that is not a hash" do
         expect do

spec/pulsar/producer_spec.rb

@@ -53,6 +53,7 @@ def send(message)
             "payload",
             properties: {"k" => "v"},
             partition_key: "foo",
+            ordering_key: "mine",
           )
         }
 
@@ -67,6 +68,10 @@ def send(message)
         it "sets partition_key" do
           expect(subject.partition_key).to eq("foo")
         end
+
+        it "sets ordering_key" do
+          expect(subject.ordering_key).to eq("mine")
+        end
       end
     end
   end