Lock down some publicly accessible structures

Author: Rycochet

src/Velocity/defaults.ts

@@ -115,18 +115,20 @@ function getSetStyle(propertyName: string) {
 const rxVendors = /^(webkit|moz|ms|o)[A-Z]/,
 	prefixElement = State.prefixElement;
 
-for (const propertyName in prefixElement.style) {
-	if (rxVendors.test(propertyName)) {
-		const unprefixed = propertyName.replace(/^[a-z]+([A-Z])/, ($, letter: string) => letter.toLowerCase());
+if (prefixElement) {
+	for (const propertyName in prefixElement.style) {
+		if (rxVendors.test(propertyName)) {
+			const unprefixed = propertyName.replace(/^[a-z]+([A-Z])/, ($, letter: string) => letter.toLowerCase());
 
-		if (ALL_VENDOR_PREFIXES || isString(prefixElement.style[unprefixed])) {
-			const addUnit = rxAddPx.test(unprefixed) ? "px" : undefined;
+			if (ALL_VENDOR_PREFIXES || isString(prefixElement.style[unprefixed])) {
+				const addUnit = rxAddPx.test(unprefixed) ? "px" : undefined;
 
-			registerNormalization(["Element", unprefixed, getSetPrefixed(propertyName, unprefixed), addUnit]);
-		}
-	} else if (!hasNormalization(["Element", propertyName])) {
-		const addUnit = rxAddPx.test(propertyName) ? "px" : undefined;
+				registerNormalization(["Element", unprefixed, getSetPrefixed(propertyName, unprefixed), addUnit]);
+			}
+		} else if (!hasNormalization(["Element", propertyName])) {
+			const addUnit = rxAddPx.test(propertyName) ? "px" : undefined;
 
-		registerNormalization(["Element", propertyName, getSetStyle(propertyName), addUnit]);
+			registerNormalization(["Element", propertyName, getSetStyle(propertyName), addUnit]);
+		}
 	}
 }

src/Velocity/normalizations/style.ts

@@ -16,10 +16,7 @@ const isClient = window && window === window.window,
 export const State: VelocityState = {
 	isClient,
 	isMobile: isClient && /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(navigator.userAgent),
-	isAndroid: isClient && /Android/i.test(navigator.userAgent),
 	isGingerbread: isClient && /Android 2\.3\.[3-7]/i.test(navigator.userAgent),
-	isChrome: isClient && (window as any).chrome,
-	isFirefox: isClient && /Firefox/i.test(navigator.userAgent),
 	prefixElement: isClient && document.createElement("div"),
 	windowScrollAnchor,
 	scrollAnchor: windowScrollAnchor ? window : (!isClient || document.documentElement || document.body.parentNode || document.body),

src/Velocity/state.ts

@@ -60,7 +60,7 @@ namespace VelocityStatic {
 	/**
 	 * Velocity option defaults, which can be overriden by the user.
 	 */
-	export const defaults: StrictVelocityOptions & {reset?: () => void} = DefaultObject;
+	export const defaults: StrictVelocityOptions & {reset?: () => void} = DefaultObject as any;
 
 	/**
 	 * Used to patch any object to allow Velocity chaining. In order to chain an
@@ -182,4 +182,6 @@ for (const property in VelocityStatic) {
 	}
 }
 
+Object.freeze(Velocity);
+
 export default Velocity; // tslint:disable-line:no-default-export

src/velocity.ts

@@ -25,8 +25,8 @@ declare global {
 	}
 }
 
-export const isMobile = /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(navigator.userAgent),
-	isAndroid = /Android/i.test(navigator.userAgent),
+export const $ = ((window as any).jQuery || (window as any).Zepto),
+	$qunitStage = document.getElementById("qunit-stage"),
 	defaultStyles = {
 		opacity: 1,
 		width: 1,
@@ -51,8 +51,6 @@ export const isMobile = /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Oper
 		delay: 0,
 		mobileHA: true,
 	},
-	$ = ((window as any).jQuery || (window as any).Zepto),
-	$qunitStage = document.getElementById("qunit-stage"),
 	asyncCheckDuration = (defaultOptions.duration as number) / 2,
 	completeCheckDuration = (defaultOptions.duration as number) * 2,
 	IE = (() => {

test/src/utilities.ts

@@ -1312,33 +1312,17 @@ export interface VelocityState {
 	 */
 	readonly isMobile: boolean;
 
-	/**
-	 * The mobileHA option's behavior changes on older Android devices
-	 * (Gingerbread, versions 2.3.3-2.3.7).
-	 */
-	readonly isAndroid: boolean;
-
 	/**
 	 * The mobileHA option's behavior changes on older Android devices
 	 * (Gingerbread, versions 2.3.3-2.3.7).
 	 */
 	readonly isGingerbread: boolean;
 
-	/**
-	 * Chrome browser
-	 */
-	readonly isChrome: boolean;
-
-	/**
-	 * Firefox browser
-	 */
-	readonly isFirefox: boolean;
-
 	/**
 	 * Create a cached element for re-use when checking for CSS property
 	 * prefixes.
 	 */
-	readonly prefixElement: HTMLDivElement;
+	readonly prefixElement?: HTMLDivElement;
 
 	/**
 	 * Retrieve the appropriate scroll anchor and property name for the