Merge pull request #2271 from Shaikh-Ubaid/llvm_fix_ifexp

LLVM: Fix visit_IfExp()

Author: ubaidsk

integration_tests/CMakeLists.txt

@@ -626,6 +626,7 @@ RUN(NAME test_global         LABELS cpython llvm c)
 RUN(NAME test_global_decl    LABELS cpython llvm c)
 RUN(NAME test_ifexp_01          LABELS cpython llvm c)
 RUN(NAME test_ifexp_02          LABELS cpython llvm c)
+RUN(NAME test_ifexp_03          LABELS cpython llvm c)
 RUN(NAME test_unary_op_01    LABELS cpython llvm c) # unary minus
 RUN(NAME test_unary_op_02    LABELS cpython llvm c) # unary plus
 RUN(NAME test_unary_op_03    LABELS cpython llvm c wasm) # unary bitinvert

integration_tests/test_ifexp_01.py

@@ -3,9 +3,12 @@
 def f():
     i: i32
     i = 1 if True else 0
+    print (i)
     assert i == 1
+
     j: f32
     j = f32(1.0 if 1.0 <= 0.0 else 0.0)
+    print(j)
     assert j == f32(0.0)
 
 f()

integration_tests/test_ifexp_03.py

@@ -0,0 +1,11 @@
+from lpython import i32
+
+def fib(n: i32) -> i32:
+    return fib(n - 1) + fib(n - 2) if n >= 3 else 1
+
+def main0():
+    res: i32 = fib(30)
+    print(res)
+    assert res == 832040
+
+main0()

src/libasr/codegen/asr_to_llvm.cpp

@@ -5127,11 +5127,16 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
         // IfExp(expr test, expr body, expr orelse, ttype type, expr? value)
         this->visit_expr_wrapper(x.m_test, true);
         llvm::Value *cond = tmp;
-        this->visit_expr_wrapper(x.m_body, true);
-        llvm::Value *then_val = tmp;
-        this->visit_expr_wrapper(x.m_orelse, true);
-        llvm::Value *else_val = tmp;
-        tmp = builder->CreateSelect(cond, then_val, else_val);
+        llvm::Type* _type = llvm_utils->get_type_from_ttype_t_util(x.m_type, module.get());
+        llvm::Value* ifexp_res = builder->CreateAlloca(_type);
+        llvm_utils->create_if_else(cond, [&]() {
+            this->visit_expr_wrapper(x.m_body, true);
+            builder->CreateStore(tmp, ifexp_res);
+        }, [&]() {
+            this->visit_expr_wrapper(x.m_orelse, true);
+            builder->CreateStore(tmp, ifexp_res);
+        });
+        tmp = CreateLoad(ifexp_res);
     }
 
     // TODO: Implement visit_DooLoop