process: make exitCode configurable again

ljharb · web-flow · commit 6bff7d92b240 · 2023-09-09T15:28:21.000-07:00
This change was done in nodejs#44711, and it's not clear it was intentional. It caused nodejs#45683, and also makes it impossible to mock out the exitCode in tests. Filing this PR per nodejs#44711 (comment) Fixes nodejs#45683.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -129,7 +129,7 @@ process.domain = null;
       exitCode = code;
     },
     enumerable: true,
-    configurable: false,
+    configurable: true,
   });
 }
 process._exiting = false;

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ process.domain = null;`
`129`	`129`	`exitCode = code;`
`130`	`130`	`},`
`131`	`131`	`enumerable: true,`
`132`		`- configurable: false,`
	`132`	`+ configurable: true,`
`133`	`133`	`});`
`134`	`134`	`}`
`135`	`135`	`process._exiting = false;`