This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Allow filtering for admins in the list accounts admin API#16114
Merged
DMRobertson merged 2 commits intomatrix-org:developfrom Aug 18, 2023
Merged
Allow filtering for admins in the list accounts admin API#16114DMRobertson merged 2 commits intomatrix-org:developfrom
DMRobertson merged 2 commits intomatrix-org:developfrom
Conversation
Member
f099d80 to
12abef8
Compare
DMRobertson
reviewed
Aug 15, 2023
DMRobertson
reviewed
Aug 15, 2023
DMRobertson
reviewed
Aug 15, 2023
DMRobertson
reviewed
Aug 15, 2023
DMRobertson
reviewed
Aug 15, 2023
Comment on lines
+227
to
+231
| filters.append("admin = 1") | ||
| else: | ||
| filters.append("admin = 0") |
DMRobertson
suggested changes
Aug 15, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
I'd like to see the docs and docstring phrasing changed; everything else is a nice-to-have.
12abef8 to
e734acb
Compare
DMRobertson
reviewed
Aug 15, 2023
| @@ -0,0 +1 @@ | |||
| Query-Parameter added to Admin-API /users to filter admins from user list. No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Query-Parameter added to Admin-API /users to filter admins from user list. | |
| Add an `admins` query parameter to the [List Accounts](https://matrix-org.github.io/synapse/v1.91/admin_api/user_admin_api.html#list-accounts) [admin API](https://matrix-org.github.io/synapse/v1.91/usage/administration/admin_api/index.html), to include only admins or to exclude admins in user queries. |
Contributor
There was a problem hiding this comment.
Sorry, I missed the changelog earlier.
Contributor
Author
There was a problem hiding this comment.
I have adopted the text.
Signed-off-by: Alexander Fechler <alexander.fechler@bwi.de>
e734acb to
48feabf
Compare
DMRobertson
approved these changes
Aug 15, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Thanks, I'm happy if CI is!
Contributor
|
CI passed except for a flake on 48feabf, going to merge manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)