This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Reduce DB contention on worker locks#16160
Merged
erikjohnston merged 3 commits intodevelopfrom Aug 23, 2023
Merged
Conversation
reivilibre
approved these changes
Aug 23, 2023
| VALUES (NEW.lock_name, NEW.lock_key, NEW.write_lock, NEW.token) | ||
| ON CONFLICT (lock_name, lock_key) | ||
| DO UPDATE SET write_lock = NEW.write_lock | ||
| WHERE OLD.write_lock != NEW.write_lock; |
Contributor
There was a problem hiding this comment.
I thought it worthwhile to check the semantics of the WHERE here to ensure they still create the row lock:
Only rows for which this expression returns true will be updated, although all rows will be locked when the ON CONFLICT DO UPDATE action is taken.
— Postgres manual
Seems fine then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to upsert the
tokenevery time we took out the lock. Instead, we only update an existing value when we have a conflictingwrite_lockvalue (which will then fail the foreign key constraint).