Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Support releasing on macOS.#16266

Merged
clokep merged 2 commits intorelease-v1.92from
clokep/release-macos
Sep 7, 2023
Merged

Support releasing on macOS.#16266
clokep merged 2 commits intorelease-v1.92from
clokep/release-macos

Conversation

@clokep
Copy link
Copy Markdown
Member

@clokep clokep commented Sep 6, 2023

These were changes I had to make to the release script in order to get 1.91.2 out the door.

Comment thread scripts-dev/release.py
Comment on lines 577 to 578
# Try and run notify-send, but don't raise an Exception if this fails
# (This is best-effort)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lie -- I got an exception that the binary couldn't be found.

@clokep clokep marked this pull request as ready for review September 6, 2023 17:30
@clokep clokep requested a review from a team as a code owner September 6, 2023 17:30
@clokep clokep changed the title Support releases on macOS. Support releasing on macOS. Sep 6, 2023
@clokep clokep merged commit 7e98d38 into release-v1.92 Sep 7, 2023
@clokep clokep deleted the clokep/release-macos branch September 7, 2023 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants