This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix "'int' object is not iterable" error in set_device_id_for_pushers background update#16594
Merged
clokep merged 2 commits intorelease-v1.96from Nov 2, 2023
Merged
Fix "'int' object is not iterable" error in set_device_id_for_pushers background update#16594clokep merged 2 commits intorelease-v1.96from
clokep merged 2 commits intorelease-v1.96from
Conversation
DMRobertson
reviewed
Nov 2, 2023
| table="pushers", | ||
| key_names=("id",), | ||
| key_values=[row[0] for row in rows], | ||
| key_values=[(row[0],) for row in rows], |
Contributor
There was a problem hiding this comment.
Whoops, is this from the cursor_to_dict changes?
I guess this means we don't have any test coverage for this background update? :(
Member
Author
There was a problem hiding this comment.
From #16431, yes. Probably not... we should probably fail unit tests if any errors happen in the background, but there's no guarantee this actually runs with any data?
DMRobertson
approved these changes
Nov 2, 2023
clokep
force-pushed
the
clokep/fix-tuples
branch
from
25e236b to
43a023d
Compare
Member
Author
|
Going to target the 1.96 branch with this since the background update won't be more broken if this doesn't work properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16591