Skip to content

Commit 21e7873

Browse files
westey-mwestey-m
authored
.NET: Disable flakey Workflow Observability tests (#4416)
* Disable flakey OffThread test * Disable additional OffThread test * Disable a further test * Disable all observability tests
1 parent 5dcf45b commit 21e7873

2 files changed

Lines changed: 22 additions & 22 deletions

File tree

‎dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/ObservabilityTests.cs‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -133,31 +133,31 @@ private async Task TestWorkflowEndToEndActivitiesAsync(string executionEnvironme
133133
activityEvents.Should().Contain(e => e.Name == EventNames.WorkflowCompleted, "activity should have workflow completed event");
134134
}
135135

136-
[Fact]
136+
[Fact(Skip = "Flaky test - temporarily disabled.")]
137137
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_DefaultAsync()
138138
{
139139
await this.TestWorkflowEndToEndActivitiesAsync("Default");
140140
}
141141

142-
[Fact(Skip = "Flaky test - temporarily disabled. Tracked in #12345")]
142+
[Fact(Skip = "Flaky test - temporarily disabled.")]
143143
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_OffThreadAsync()
144144
{
145145
await this.TestWorkflowEndToEndActivitiesAsync("OffThread");
146146
}
147147

148-
[Fact]
148+
[Fact(Skip = "Flaky test - temporarily disabled.")]
149149
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_ConcurrentAsync()
150150
{
151151
await this.TestWorkflowEndToEndActivitiesAsync("Concurrent");
152152
}
153153

154-
[Fact]
154+
[Fact(Skip = "Flaky test - temporarily disabled.")]
155155
public async Task CreatesWorkflowEndToEndActivities_WithCorrectName_LockstepAsync()
156156
{
157157
await this.TestWorkflowEndToEndActivitiesAsync("Lockstep");
158158
}
159159

160-
[Fact]
160+
[Fact(Skip = "Flaky test - temporarily disabled.")]
161161
public async Task CreatesWorkflowActivities_WithCorrectNameAsync()
162162
{
163163
// Arrange
@@ -182,7 +182,7 @@ public async Task CreatesWorkflowActivities_WithCorrectNameAsync()
182182
tags.Should().ContainKey(Tags.WorkflowDefinition);
183183
}
184184

185-
[Fact]
185+
[Fact(Skip = "Flaky test - temporarily disabled.")]
186186
public async Task TelemetryDisabledByDefault_CreatesNoActivitiesAsync()
187187
{
188188
// Arrange
@@ -200,7 +200,7 @@ public async Task TelemetryDisabledByDefault_CreatesNoActivitiesAsync()
200200
capturedActivities.Should().BeEmpty("No activities should be created when telemetry is disabled (default).");
201201
}
202202

203-
[Fact]
203+
[Fact(Skip = "Flaky test - temporarily disabled.")]
204204
public async Task WithOpenTelemetry_UsesProvidedActivitySourceAsync()
205205
{
206206
// Arrange
@@ -235,7 +235,7 @@ public async Task WithOpenTelemetry_UsesProvidedActivitySourceAsync()
235235
"All activities should come from the user-provided ActivitySource.");
236236
}
237237

238-
[Fact]
238+
[Fact(Skip = "Flaky test - temporarily disabled.")]
239239
public async Task DisableWorkflowBuild_PreventsWorkflowBuildActivityAsync()
240240
{
241241
// Arrange
@@ -255,7 +255,7 @@ public async Task DisableWorkflowBuild_PreventsWorkflowBuildActivityAsync()
255255
"WorkflowBuild activity should be disabled.");
256256
}
257257

258-
[Fact]
258+
[Fact(Skip = "Flaky test - temporarily disabled.")]
259259
public async Task DisableWorkflowRun_PreventsWorkflowRunActivityAsync()
260260
{
261261
// Arrange
@@ -285,7 +285,7 @@ public async Task DisableWorkflowRun_PreventsWorkflowRunActivityAsync()
285285
"Other activities should still be created.");
286286
}
287287

288-
[Fact]
288+
[Fact(Skip = "Flaky test - temporarily disabled.")]
289289
public async Task DisableExecutorProcess_PreventsExecutorProcessActivityAsync()
290290
{
291291
// Arrange
@@ -312,7 +312,7 @@ public async Task DisableExecutorProcess_PreventsExecutorProcessActivityAsync()
312312
"Other activities should still be created.");
313313
}
314314

315-
[Fact]
315+
[Fact(Skip = "Flaky test - temporarily disabled.")]
316316
public async Task DisableEdgeGroupProcess_PreventsEdgeGroupProcessActivityAsync()
317317
{
318318
// Arrange
@@ -333,7 +333,7 @@ public async Task DisableEdgeGroupProcess_PreventsEdgeGroupProcessActivityAsync(
333333
"Other activities should still be created.");
334334
}
335335

336-
[Fact]
336+
[Fact(Skip = "Flaky test - temporarily disabled.")]
337337
public async Task DisableMessageSend_PreventsMessageSendActivityAsync()
338338
{
339339
// Arrange
@@ -382,7 +382,7 @@ private static Workflow CreateWorkflowWithDisabledMessages()
382382
return builder.WithOpenTelemetry(configure: opts => opts.DisableMessageSend = true).Build();
383383
}
384384

385-
[Fact]
385+
[Fact(Skip = "Flaky test - temporarily disabled.")]
386386
public async Task EnableSensitiveData_LogsExecutorInputAndOutputAsync()
387387
{
388388
// Arrange
@@ -413,7 +413,7 @@ public async Task EnableSensitiveData_LogsExecutorInputAndOutputAsync()
413413
tags[Tags.ExecutorOutput].Should().Contain("HELLO", "Output should contain the transformed value.");
414414
}
415415

416-
[Fact]
416+
[Fact(Skip = "Flaky test - temporarily disabled.")]
417417
public async Task EnableSensitiveData_Disabled_DoesNotLogInputOutputAsync()
418418
{
419419
// Arrange
@@ -442,7 +442,7 @@ public async Task EnableSensitiveData_Disabled_DoesNotLogInputOutputAsync()
442442
tags.Should().NotContainKey(Tags.ExecutorOutput, "Output should NOT be logged when EnableSensitiveData is false.");
443443
}
444444

445-
[Fact]
445+
[Fact(Skip = "Flaky test - temporarily disabled.")]
446446
public async Task EnableSensitiveData_LogsMessageSendContentAsync()
447447
{
448448
// Arrange
@@ -474,7 +474,7 @@ public async Task EnableSensitiveData_LogsMessageSendContentAsync()
474474
tags.Should().ContainKey(Tags.MessageSourceId, "Source ID should be logged.");
475475
}
476476

477-
[Fact]
477+
[Fact(Skip = "Flaky test - temporarily disabled.")]
478478
public async Task EnableSensitiveData_Disabled_DoesNotLogMessageContentAsync()
479479
{
480480
// Arrange

‎dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowRunActivityStopTests.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private static Workflow CreateWorkflow()
6767
/// Bug: The Activity created by LockstepRunEventStream.TakeEventStreamAsync is never
6868
/// disposed because yield break in async iterators does not trigger using disposal.
6969
/// </summary>
70-
[Fact]
70+
[Fact(Skip = "Flaky test - temporarily disabled.")]
7171
public async Task WorkflowRunActivity_IsStopped_LockstepAsync()
7272
{
7373
// Arrange
@@ -111,7 +111,7 @@ public async Task WorkflowRunActivity_IsStopped_LockstepAsync()
111111
/// Verifies that the workflow_invoke Activity is stopped when using the OffThread (Default)
112112
/// execution environment (StreamingRunEventStream).
113113
/// </summary>
114-
[Fact]
114+
[Fact(Skip = "Flaky test - temporarily disabled.")]
115115
public async Task WorkflowRunActivity_IsStopped_OffThreadAsync()
116116
{
117117
// Arrange
@@ -156,7 +156,7 @@ public async Task WorkflowRunActivity_IsStopped_OffThreadAsync()
156156
/// (StreamingRun.WatchStreamAsync) with the OffThread execution environment.
157157
/// This matches the exact usage pattern described in the issue.
158158
/// </summary>
159-
[Fact]
159+
[Fact(Skip = "Flaky test - temporarily disabled.")]
160160
public async Task WorkflowRunActivity_IsStopped_Streaming_OffThreadAsync()
161161
{
162162
// Arrange
@@ -203,7 +203,7 @@ public async Task WorkflowRunActivity_IsStopped_Streaming_OffThreadAsync()
203203
/// streaming invocation, even when using the same workflow in a multi-turn pattern,
204204
/// and that each session gets its own session activity.
205205
/// </summary>
206-
[Fact]
206+
[Fact(Skip = "Flaky test - temporarily disabled.")]
207207
public async Task WorkflowRunActivity_IsStopped_Streaming_OffThread_MultiTurnAsync()
208208
{
209209
// Arrange
@@ -264,7 +264,7 @@ public async Task WorkflowRunActivity_IsStopped_Streaming_OffThread_MultiTurnAsy
264264
/// Verifies that all started activities (not just workflow_invoke) are properly stopped.
265265
/// This ensures no spans are "leaked" without being exported.
266266
/// </summary>
267-
[Fact]
267+
[Fact(Skip = "Flaky test - temporarily disabled.")]
268268
public async Task AllActivities_AreStopped_AfterWorkflowCompletionAsync()
269269
{
270270
// Arrange
@@ -305,7 +305,7 @@ public async Task AllActivities_AreStopped_AfterWorkflowCompletionAsync()
305305
/// be parented under the workflow session span. The run activity should
306306
/// still nest correctly under the session.
307307
/// </summary>
308-
[Fact]
308+
[Fact(Skip = "Flaky test - temporarily disabled.")]
309309
public async Task Lockstep_SessionActivity_DoesNotLeak_IntoCaller_ActivityCurrentAsync()
310310
{
311311
// Arrange

0 commit comments

Comments
 (0)