Skip to content

Commit 120dde0

Browse files
authored
refactor!: restructure RPI collection to HVE Core naming convention (#668)
This PR promotes the RPI collection to flagship status by renaming it to **HVE Core** and redesigning how repo-specific AI artifacts are identified and excluded from distribution. The change touches every layer of the system: artifact directories, collection manifests, plugin outputs, extension packaging, validation scripts, tests, and documentation. Previously, all RPI workflow agents, prompts, and instructions lived under `.github/{type}/rpi/` directories, and repo-specific artifacts were identified by living under an `hve-core/` subdirectory. This created a collision: the `hve-core/` name was simultaneously used for repo-internal exclusions and as the natural identity for the flagship collection. The restructuring resolves this by: - **Moving all `.github/{type}/rpi/` directories to `.github/{type}/hve-core/`**, making the collection identity match the project name. - **Replacing the subdirectory-based exclusion convention with root-level detection.** Repo-specific artifacts now live directly at the root of `.github/agents/`, `.github/instructions/`, `.github/prompts/`, or `.github/skills/` (no subdirectory). Collection-scoped, distributable artifacts reside in subdirectories like `hve-core/`, `ado/`, `shared/`, etc. - **Updating the exclusion functions** `Test-HveCoreRepoSpecificPath` (from `$RelativePath -like 'hve-core/*'` to `$RelativePath -notlike '*/*'`) and `Test-HveCoreRepoRelativePath` (from `.github/.*/hve-core/` regex to `^\.github/(agents|instructions|prompts|skills)/[^/]+$`). - **Renaming `rpi.collection.yml` to `hve-core.collection.yml`** with updated metadata, and creating the corresponding `plugins/hve-core/` output directory while removing `plugins/rpi/`. - **Reassigning the flagship extension identity from `hve-core-all` to `hve-core`**, so the `hve-core` collection now produces `extension/package.json` and `extension/README.md` (the default extension artifacts), while `hve-core-all` gets explicit `package.hve-core-all.json` and `README.hve-core-all.md` files. - **Updating marketplace.json** to register the new `hve-core` plugin entry and remove the `rpi` entry. - **Updating VS Code settings** (`.vscode/settings.json`) to point at the new `hve-core` directories instead of `rpi`. - **Updating all internal cross-references** within agents, subagents, documentation, the installer agent, workflow README, and contributing guides to use `hve-core/` paths. - **Rewriting all affected tests** across `PluginHelpers.Tests.ps1`, `Validate-Collections.Tests.ps1`, and `Prepare-Extension.Tests.ps1` to validate the new root-level exclusion convention and updated collection identity. ## Related Issue(s) <!-- Link to the issue(s) this PR addresses using "Fixes #123" or "Closes #123" --> ## Type of Change Select all that apply: **Code & Documentation:** - [ ] Bug fix (non-breaking change fixing an issue) - [ ] New feature (non-breaking change adding functionality) - [x] Breaking change (fix or feature causing existing functionality to change) - [x] Documentation update **Infrastructure & Configuration:** - [ ] GitHub Actions workflow - [ ] Linting configuration (markdown, PowerShell, etc.) - [ ] Security configuration - [ ] DevContainer configuration - [ ] Dependency update **AI Artifacts:** - [ ] Reviewed contribution with `prompt-builder` agent and addressed all feedback - [x] Copilot instructions (`.github/instructions/*.instructions.md`) - [x] Copilot prompt (`.github/prompts/*.prompt.md`) - [x] Copilot agent (`.github/agents/*.agent.md`) - [ ] Copilot skill (`.github/skills/*/SKILL.md`) > **Note for AI Artifact Contributors**: > > - **Agents**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones. > - **Skills**: Must include both bash and PowerShell scripts. See [Skills](../docs/contributing/skills.md). > - **Model Versions**: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected. > - See [Agents Not Accepted](../docs/contributing/custom-agents.md#agents-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements). **Other:** - [x] Script/automation (`.ps1`, `.sh`, `.py`) - [ ] Other (please describe): ## Sample Prompts (for AI Artifact Contributions) Not applicable — this PR renames and restructures existing artifacts without changing their behavior. All agents, prompts, and instructions retain their original functionality under new paths. ## Testing - `PluginHelpers.Tests.ps1` — 46/46 passing, validates root-level exclusion logic (`Test-HveCoreRepoSpecificPath`, `Test-HveCoreRepoRelativePath`) and `Get-ArtifactFiles` filtering. - `Validate-Collections.Tests.ps1` — 18/18 passing, validates that root-level repo-specific paths are rejected from collection manifests while subdirectory paths are accepted. - `Prepare-Extension.Tests.ps1` — 131/131 passing, validates updated flagship collection identity, extension packaging, collection generation, and maturity filtering with `hve-core` as the default collection. ## Checklist ### Required Checks - [x] Documentation is updated (if applicable) - [x] Files follow existing naming conventions - [ ] Changes are backwards compatible (if applicable) - [x] Tests added for new functionality (if applicable) ### AI Artifact Contributions <!-- If contributing an agent, prompt, instruction, or skill, complete these checks --> - [ ] Used `/prompt-analyze` to review contribution - [ ] Addressed all feedback from `prompt-builder` review - [ ] Verified contribution follows common standards and type-specific requirements ### Required Automated Checks The following validation commands must pass before merging: - [x] Markdown linting: `npm run lint:md` - [x] Spell checking: `npm run spell-check` - [x] Frontmatter validation: `npm run lint:frontmatter` - [x] Skill structure validation: `npm run validate:skills` - [x] Link validation: `npm run lint:md-links` - [x] PowerShell analysis: `npm run lint:ps` ## GHCP Artifact Maturity > [!WARNING] > This PR includes **experimental** GHCP artifacts that may have breaking changes. > - `.github/agents/hve-core/doc-ops.agent.md` > - `.github/prompts/hve-core/checkpoint.prompt.md` | File | Type | Maturity | Notes | |---|---|---|---| | `.github/agents/hve-core/doc-ops.agent.md` | Agent | ⚠️ experimental | Renamed from `rpi/` | | `.github/agents/hve-core/memory.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/pr-review.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/prompt-builder.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/rpi-agent.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/task-implementor.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/task-planner.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/task-researcher.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/task-reviewer.agent.md` | Agent | ✅ stable | Renamed from `rpi/` | | `.github/agents/hve-core/subagents/prompt-evaluator.agent.md` | Agent | ✅ stable | Renamed from `rpi/subagents/` | | `.github/agents/hve-core/subagents/prompt-updater.agent.md` | Agent | ✅ stable | Renamed from `rpi/subagents/` | | `.github/prompts/hve-core/checkpoint.prompt.md` | Prompt | ⚠️ experimental | Renamed from `rpi/` | | `.github/prompts/hve-core/task-research.prompt.md` | Prompt | ✅ stable | Renamed from `rpi/` | | `.github/prompts/hve-core/task-plan.prompt.md` | Prompt | ✅ stable | Renamed from `rpi/` | | `.github/prompts/hve-core/task-implement.prompt.md` | Prompt | ✅ stable | Renamed from `rpi/` | | `.github/prompts/hve-core/task-review.prompt.md` | Prompt | ✅ stable | Renamed from `rpi/` | | `.github/prompts/hve-core/pull-request.prompt.md` | Prompt | ✅ stable | Renamed from `rpi/` | | `.github/prompts/hve-core/git-commit.prompt.md` | Prompt | ✅ stable | Renamed from `rpi/` | | `.github/prompts/hve-core/git-merge.prompt.md` | Prompt | ✅ stable | Renamed from `rpi/` | | `.github/instructions/hve-core/commit-message.instructions.md` | Instructions | ✅ stable | Renamed from `rpi/` | | `.github/instructions/hve-core/git-merge.instructions.md` | Instructions | ✅ stable | Renamed from `rpi/` | | `.github/instructions/hve-core/markdown.instructions.md` | Instructions | ✅ stable | Renamed from `rpi/` | | `.github/instructions/hve-core/prompt-builder.instructions.md` | Instructions | ✅ stable | Renamed from `rpi/` | | `.github/instructions/hve-core/writing-style.instructions.md` | Instructions | ✅ stable | Renamed from `rpi/` | | `.github/instructions/workflows.instructions.md` | Instructions | ✅ stable | Moved to root-level (repo-specific) | ### GHCP Maturity Acknowledgment - [x] I acknowledge this PR includes non-stable GHCP artifacts - [x] Non-stable artifacts are intentional for this change ## Security Considerations <!-- ⚠️ WARNING: Do not commit sensitive information such as API keys, passwords, or personal data --> - [x] This PR does not contain any sensitive or NDA information - [ ] Any new dependencies have been reviewed for security issues - [x] Security-related scripts follow the principle of least privilege ## Additional Notes - **Plugin installation command changed**: `copilot plugin install rpi@hve-core` becomes `copilot plugin install hve-core@hve-core`. - **VS Code settings paths changed**: Users referencing `rpi` directories in `chat.agentFilesLocations`, `chat.promptFilesLocations`, or `chat.instructionsFilesLocations` must update to `hve-core`. - The `workflows.instructions.md` file moved from `.github/instructions/hve-core/` (collection-scoped) to `.github/instructions/` (root-level, repo-specific), reflecting that it applies only to this repository's CI workflows. 🔄 - Generated by Copilot
1 parent 11b93cb commit 120dde0

File tree

190 files changed

+600
-555
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

190 files changed

+600
-555
lines changed
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ Run three `researcher-subagent` agents in parallel with `runSubagent` or `task`
146146
Run a `researcher-subagent` agent with:
147147

148148
* Task: Scan all in-scope files for divergences from writing-style.instructions.md and markdown.instructions.md.
149-
* Instructions to read: [writing-style.instructions.md](.github/instructions/rpi/writing-style.instructions.md), [markdown.instructions.md](.github/instructions/rpi/markdown.instructions.md).
149+
* Instructions to read: [writing-style.instructions.md](.github/instructions/hve-core/writing-style.instructions.md), [markdown.instructions.md](.github/instructions/hve-core/markdown.instructions.md).
150150
* File scope: All files matching Included Files patterns, excluding Excluded Files patterns.
151151
* Response format: List each issue with file path, line number, violation type, and suggested fix.
152152
* Requirement: Indicate whether additional passes are needed and report total issue count.
@@ -208,7 +208,7 @@ If using the `runSubagent` tool then include instructions for each to read and f
208208
Each `phase-implementor` agent receives:
209209

210210
* Task: Execute assigned work items from the plan.
211-
* Instructions to follow: [writing-style.instructions.md](.github/instructions/rpi/writing-style.instructions.md), [markdown.instructions.md](.github/instructions/rpi/markdown.instructions.md).
211+
* Instructions to follow: [writing-style.instructions.md](.github/instructions/hve-core/writing-style.instructions.md), [markdown.instructions.md](.github/instructions/hve-core/markdown.instructions.md).
212212
* Work items: Specific numbered items from the plan.
213213
* Response format: Report each change with file path, change description, and completion status.
214214
* Requirement: Report any new issues discovered during implementation and whether additional passes are needed.
@@ -256,8 +256,8 @@ Prompt:
256256
You are a documentation discovery subagent. Your task is to [CAPABILITY FOCUS].
257257
258258
Read and apply conventions from:
259-
- .github/instructions/rpi/writing-style.instructions.md
260-
- .github/instructions/rpi/markdown.instructions.md
259+
- .github/instructions/hve-core/writing-style.instructions.md
260+
- .github/instructions/hve-core/markdown.instructions.md
261261
262262
Scope: Process only these file patterns:
263263
[IN-SCOPE PATTERNS]
@@ -315,8 +315,8 @@ Prompt:
315315
You are a documentation implementation subagent. Execute fixes from the work plan.
316316
317317
Read and follow conventions from:
318-
- .github/instructions/rpi/writing-style.instructions.md
319-
- .github/instructions/rpi/markdown.instructions.md
318+
- .github/instructions/hve-core/writing-style.instructions.md
319+
- .github/instructions/hve-core/markdown.instructions.md
320320
321321
Work items to complete:
322322
[NUMBERED WORK ITEMS]
@@ -409,4 +409,4 @@ When all phases complete, provide:
409409
| Validation Status | Passed, Failed with count, or Partial |
410410
| Followup Items | Count requiring manual intervention |
411411

412-
Suggest a commit message following [commit-message.instructions.md](.github/instructions/rpi/commit-message.instructions.md). Exclude `.copilot-tracking/` files from the commit.
412+
Suggest a commit message following [commit-message.instructions.md](.github/instructions/hve-core/commit-message.instructions.md). Exclude `.copilot-tracking/` files from the commit.
File renamed without changes.
File renamed without changes.
File renamed without changes.

.github/agents/rpi/subagents/implementation-validator.agent.md renamed to .github/agents/hve-core/subagents/implementation-validator.agent.md

File renamed without changes.

.github/agents/rpi/subagents/phase-implementor.agent.md renamed to .github/agents/hve-core/subagents/phase-implementor.agent.md

File renamed without changes.

.github/agents/rpi/subagents/plan-validator.agent.md renamed to .github/agents/hve-core/subagents/plan-validator.agent.md

File renamed without changes.

.github/agents/rpi/subagents/prompt-evaluator.agent.md renamed to .github/agents/hve-core/subagents/prompt-evaluator.agent.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ Create and update an *evaluation-log.md* file in the sandbox folder and progress
3838
### Pre-requisite: Load Evaluation Context
3939

4040
1. Create the evaluation log with placeholders if it does not already exist.
41-
2. Read and follow instructions from `.github/instructions/rpi/prompt-builder.instructions.md` in full for prompt engineering quality standards.
42-
3. Read and follow instructions from `.github/instructions/rpi/writing-style.instructions.md` in full for style standards.
41+
2. Read and follow instructions from `.github/instructions/hve-core/prompt-builder.instructions.md` in full for prompt engineering quality standards.
42+
3. Read and follow instructions from `.github/instructions/hve-core/writing-style.instructions.md` in full for style standards.
4343

4444
### Step 1: Evaluate Execution Log Findings
4545

.github/agents/rpi/subagents/prompt-tester.agent.md renamed to .github/agents/hve-core/subagents/prompt-tester.agent.md

File renamed without changes.

0 commit comments

Comments
 (0)