Skip to content

Commit 7f37790

Browse files
committed
updating code review changes
1 parent f05303d commit 7f37790

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

components/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/RedirectHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ Request getRedirect(
179179

180180
final Request followup =
181181
shouldRedirect
182-
? getRedirect(request, response, redirectOption, chain)
182+
? getRedirect(request, response, redirectOption)
183183
: null;
184184
if (followup != null) {
185185
response.close();

components/http/okHttp/src/test/java/com/microsoft/kiota/http/middleware/RedirectHandlerTests.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void crossHostRedirectStripsAuthHeaders() throws Exception {
8585
Interceptor.Chain chain = mock(Interceptor.Chain.class);
8686

8787
RedirectHandlerOption option = new RedirectHandlerOption();
88-
Request result = new RedirectHandler().getRedirect(original, redirect, option, chain);
88+
Request result = new RedirectHandler().getRedirect(original, redirect, option);
8989
assertNotNull(result);
9090
assertEquals("evil.attacker.com", result.url().host());
9191
assertNull(result.header("Authorization")); // stripped (good)
@@ -145,7 +145,7 @@ void sameHostRedirectKeepsAllHeaders() throws Exception {
145145
RedirectHandlerOption option = new RedirectHandlerOption();
146146
Request result =
147147
new RedirectHandler(option, proxySelector)
148-
.getRedirect(original, redirect, option, chain);
148+
.getRedirect(original, redirect, option);
149149

150150
assertNotNull(result);
151151
assertEquals("trusted.example.com", result.url().host());
@@ -182,7 +182,7 @@ void crossHostRedirectWithProxyKeepsProxyAuth() throws Exception {
182182
RedirectHandlerOption option = new RedirectHandlerOption();
183183
Request result =
184184
new RedirectHandler(option, proxySelector)
185-
.getRedirect(original, redirect, option, chain);
185+
.getRedirect(original, redirect, option);
186186

187187
assertNotNull(result);
188188
assertEquals("other.example.com", result.url().host());
@@ -220,7 +220,7 @@ void crossHostRedirectWithDirectProxyStripsProxyAuth() throws Exception {
220220
RedirectHandlerOption option = new RedirectHandlerOption();
221221
Request result =
222222
new RedirectHandler(option, proxySelector)
223-
.getRedirect(original, redirect, option, chain);
223+
.getRedirect(original, redirect, option);
224224

225225
assertNotNull(result);
226226
assertEquals("other.example.com", result.url().host());
@@ -256,7 +256,7 @@ void schemeChangeStripsAuthHeaders() throws Exception {
256256
Interceptor.Chain chain = mock(Interceptor.Chain.class);
257257

258258
RedirectHandlerOption option = new RedirectHandlerOption();
259-
Request result = new RedirectHandler().getRedirect(original, redirect, option, chain);
259+
Request result = new RedirectHandler().getRedirect(original, redirect, option);
260260

261261
assertNotNull(result);
262262
assertEquals("trusted.example.com", result.url().host());
@@ -288,7 +288,7 @@ void redirectWithDifferentPortRemovesAuthAndCookie() throws Exception {
288288
Interceptor.Chain chain = mock(Interceptor.Chain.class);
289289

290290
RedirectHandlerOption option = new RedirectHandlerOption();
291-
Request result = new RedirectHandler().getRedirect(original, redirect, option, chain);
291+
Request result = new RedirectHandler().getRedirect(original, redirect, option);
292292

293293
assertNotNull(result);
294294
assertEquals("example.org", result.url().host());
@@ -319,7 +319,7 @@ void redirectWithSamePortKeepsAuthAndCookie() throws Exception {
319319
Interceptor.Chain chain = mock(Interceptor.Chain.class);
320320

321321
RedirectHandlerOption option = new RedirectHandlerOption();
322-
Request result = new RedirectHandler().getRedirect(original, redirect, option, chain);
322+
Request result = new RedirectHandler().getRedirect(original, redirect, option);
323323

324324
assertNotNull(result);
325325
assertEquals("example.org", result.url().host());
@@ -356,7 +356,7 @@ void customScrubberIsUsed() throws Exception {
356356
Interceptor.Chain chain = mock(Interceptor.Chain.class);
357357

358358
RedirectHandlerOption option = new RedirectHandlerOption(5, null, customScrubber);
359-
Request result = new RedirectHandler().getRedirect(original, redirect, option, chain);
359+
Request result = new RedirectHandler().getRedirect(original, redirect, option);
360360

361361
assertNotNull(result);
362362
assertEquals("other.example.com", result.url().host());
@@ -398,7 +398,7 @@ void customScrubberRemovesCustomHeaders() throws Exception {
398398
Interceptor.Chain chain = mock(Interceptor.Chain.class);
399399

400400
RedirectHandlerOption option = new RedirectHandlerOption(5, null, customScrubber);
401-
Request result = new RedirectHandler().getRedirect(original, redirect, option, chain);
401+
Request result = new RedirectHandler().getRedirect(original, redirect, option);
402402

403403
assertNotNull(result);
404404
assertEquals("other.example.com", result.url().host());

0 commit comments

Comments
 (0)