Use uint8_t const in IBlobPersistor.h (#10276)

* Use uint8_t const in IBlobPersistor.h

Some versions of clang will not compile when the array_view data for
CryptographicBuffer::CreateFromByteArray is not `uint8_t const`.

This change switches the callsites to use uint8_t const where needed.

* Change files

* Fix Blob test comparison

Co-authored-by: Julio C. Rocha <julio.rocha@microsoft.com>

Author: rozele

change/react-native-windows-195fdcc2-1b14-49aa-a0eb-06763be2eed8.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Use uint8_t const in IBlobPersistor.h",
+  "packageName": "react-native-windows",
+  "email": "erozell@outlook.com",
+  "dependentChangeType": "patch"
+}

vnext/Shared/Modules/BlobModule.cpp

@@ -139,7 +139,7 @@ vector<module::CxxModule::Method> BlobModule::getMethods() {
          auto size = blob[sizeKey].getInt();
          auto socketID = jsArgAsInt(args, 1);
 
-         winrt::array_view<uint8_t> data;
+         winrt::array_view<uint8_t const> data;
          try {
            data = persistor->ResolveMessage(std::move(blobId), offset, size);
          } catch (const std::exception &e) {
@@ -169,7 +169,7 @@ vector<module::CxxModule::Method> BlobModule::getMethods() {
            auto type = part[typeKey].asString();
            if (blobKey == type) {
              auto blob = part[dataKey];
-             winrt::array_view<uint8_t> bufferPart;
+             winrt::array_view<uint8_t const> bufferPart;
              try {
                bufferPart = persistor->ResolveMessage(
                    blob[blobIdKey].asString(), blob[offsetKey].asInt(), blob[sizeKey].asInt());
@@ -216,7 +216,7 @@ vector<module::CxxModule::Method> BlobModule::getMethods() {
 
 #pragma region IBlobPersistor
 
-winrt::array_view<uint8_t> MemoryBlobPersistor::ResolveMessage(string &&blobId, int64_t offset, int64_t size) {
+winrt::array_view<uint8_t const> MemoryBlobPersistor::ResolveMessage(string &&blobId, int64_t offset, int64_t size) {
   if (size < 1)
     return {};
 
@@ -233,7 +233,7 @@ winrt::array_view<uint8_t> MemoryBlobPersistor::ResolveMessage(string &&blobId,
   if (endBound > bytes.size() || offset >= static_cast<int64_t>(bytes.size()) || offset < 0)
     throw std::out_of_range("Offset or size out of range");
 
-  return winrt::array_view<uint8_t>(bytes.data() + offset, bytes.data() + endBound);
+  return winrt::array_view<uint8_t const>(bytes.data() + offset, bytes.data() + endBound);
 }
 
 void MemoryBlobPersistor::RemoveMessage(string &&blobId) noexcept {

vnext/Shared/Modules/BlobModule.h

@@ -30,7 +30,7 @@ class MemoryBlobPersistor final : public IBlobPersistor {
  public:
 #pragma region IBlobPersistor
 
-  winrt::array_view<uint8_t> ResolveMessage(std::string &&blobId, int64_t offset, int64_t size) override;
+  winrt::array_view<uint8_t const> ResolveMessage(std::string &&blobId, int64_t offset, int64_t size) override;
 
   void RemoveMessage(std::string &&blobId) noexcept override;
 

vnext/Shared/Modules/FileReaderModule.cpp

@@ -71,7 +71,7 @@ std::vector<module::CxxModule::Method> FileReaderModule::getMethods() {
          auto offset = blob["offset"].asInt();
          auto size = blob["size"].asInt();
 
-         winrt::array_view<uint8_t> bytes;
+         winrt::array_view<uint8_t const> bytes;
          try {
            bytes = blobPersistor->ResolveMessage(std::move(blobId), offset, size);
          } catch (const std::exception &e) {
@@ -116,7 +116,7 @@ std::vector<module::CxxModule::Method> FileReaderModule::getMethods() {
          auto offset = blob["offset"].asInt();
          auto size = blob["size"].asInt();
 
-         winrt::array_view<uint8_t> bytes;
+         winrt::array_view<uint8_t const> bytes;
          try {
            bytes = blobPersistor->ResolveMessage(std::move(blobId), offset, size);
          } catch (const std::exception &e) {

vnext/Shared/Modules/IBlobPersistor.h

@@ -18,7 +18,7 @@ struct IBlobPersistor {
   /// When an entry for blobId cannot be found.
   /// </exception>
   ///
-  virtual winrt::array_view<uint8_t> ResolveMessage(std::string &&blobId, int64_t offset, int64_t size) = 0;
+  virtual winrt::array_view<uint8_t const> ResolveMessage(std::string &&blobId, int64_t offset, int64_t size) = 0;
 
   virtual void RemoveMessage(std::string &&blobId) noexcept = 0;
 

vnext/Shared/Networking/WinRTHttpResource.cpp

@@ -249,7 +249,7 @@ fire_and_forget WinRTHttpResource::PerformSendRequest(HttpRequestMessage &&reque
       for (auto &byte : bytes) {
         byteVector.push_back(static_cast<uint8_t>(byte.asInt()));
       }
-      auto view = winrt::array_view<uint8_t>{byteVector};
+      auto view = winrt::array_view<uint8_t const>{byteVector};
       auto buffer = CryptographicBuffer::CreateFromByteArray(view);
       content = HttpBufferContent{std::move(buffer)};
     } else if (!data["string"].empty()) {