Skip to content

Commit 8725a01

Browse files
authored
Update Vestris.ResourceLib to v2.2.0 (#536)
1 parent 3d54dab commit 8725a01

5 files changed

Lines changed: 11 additions & 40 deletions

File tree

src/WingetCreateCore/WingetCreateCore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3434
</PackageReference>
3535
<PackageReference Include="Octokit" Version="9.1.2" />
36-
<PackageReference Include="Vestris.ResourceLib" Version="2.1.0" />
36+
<PackageReference Include="Vestris.ResourceLib" Version="2.2.0" />
3737
<PackageReference Include="WiX" Version="3.14.1" />
3838
<PackageReference Include="YamlDotNet" Version="15.1.1" />
3939
</ItemGroup>

src/WingetCreateTests/WingetCreateTests/Resources/TestPublisher.SingleExe.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Installers:
1111
InstallerType: exe
1212
InstallerSha256: A7803233EEDB6A4B59B3024CCF9292A6FFFB94507DC998AA67C5B745D197A5DC
1313
ProductCode: FakeProductCode
14-
PackageFamilyName: FakePackageFamilyName
14+
PackageFamilyName: Fake.PackageFamilyName_8wekyb3d8bbwe
1515
Platform:
1616
- Windows.Desktop
1717
PackageLocale: en-US

src/WingetCreateTests/WingetCreateTests/Resources/TestPublisher.TestApp.yaml

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/WingetCreateTests/WingetCreateTests/UnitTests/UpdateCommandTests.cs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,18 +67,22 @@ public void TearDown()
6767
/// </summary>
6868
/// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
6969
[Test]
70-
public async Task UpdateCommandGitHubManifestTest()
70+
public async Task UpdateAndVerifyManifestsCreated()
7171
{
72+
string installerUrl = $"https://fakedomain.com/{TestConstants.TestExeInstaller}";
73+
TestUtils.InitializeMockDownloads(TestConstants.TestExeInstaller);
74+
75+
string packageIdentifier = "TestPublisher.SingleExe";
7276
string version = "1.2.3.4";
73-
(UpdateCommand command, var initialManifestContent) = GetUpdateCommandAndManifestData(TestConstants.TestPackageIdentifier, version, this.tempPath, null);
77+
(UpdateCommand command, var initialManifestContent) = GetUpdateCommandAndManifestData(packageIdentifier, version, this.tempPath, new[] { $"{installerUrl}" });
7478
var updatedManifests = await command.ExecuteManifestUpdate(initialManifestContent, this.testCommandEvent);
7579
ClassicAssert.IsTrue(updatedManifests, "Command should have succeeded");
7680

77-
string manifestDir = Utils.GetAppManifestDirPath(TestConstants.TestPackageIdentifier, version);
81+
string manifestDir = Utils.GetAppManifestDirPath(packageIdentifier, version);
7882
var updatedManifestContents = Directory.GetFiles(Path.Combine(this.tempPath, manifestDir)).Select(f => File.ReadAllText(f));
7983
ClassicAssert.IsTrue(updatedManifestContents.Any(), "Updated manifests were not created successfully");
8084
Manifests manifestsToValidate = Serialization.DeserializeManifestContents(updatedManifestContents);
81-
ClassicAssert.AreEqual(version, manifestsToValidate.VersionManifest.PackageVersion, $"Failed to update version of {TestConstants.TestPackageIdentifier}");
85+
ClassicAssert.AreEqual(version, manifestsToValidate.VersionManifest.PackageVersion, $"Failed to update version of {packageIdentifier}");
8286
}
8387

8488
/// <summary>
@@ -598,7 +602,7 @@ public async Task UpdatePreservesExistingValues()
598602
ClassicAssert.IsNotNull(updatedManifests, "Command should have succeeded");
599603
var updatedInstallerManifest = updatedManifests.InstallerManifest;
600604
ClassicAssert.AreEqual("FakeProductCode", updatedInstallerManifest.ProductCode, "Existing value for ProductCode was overwritten.");
601-
ClassicAssert.AreEqual("FakePackageFamilyName", updatedInstallerManifest.PackageFamilyName, "Existing value for PackageFamilyName was overwritten.");
605+
ClassicAssert.AreEqual("Fake.PackageFamilyName_8wekyb3d8bbwe", updatedInstallerManifest.PackageFamilyName, "Existing value for PackageFamilyName was overwritten.");
602606
ClassicAssert.IsNotNull(updatedInstallerManifest.Platform, "Existing value for Platform was overwritten.;");
603607
}
604608

src/WingetCreateTests/WingetCreateTests/WingetCreateTests.csproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,6 @@
189189
<None Update="Resources\WingetCreateE2E.Yaml.MsiTest.yaml">
190190
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
191191
</None>
192-
<None Update="Resources\TestPublisher.TestApp.yaml">
193-
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
194-
</None>
195192
<None Update="Resources\TestPublisher.MultipleInstallerApp.yaml">
196193
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
197194
</None>

0 commit comments

Comments
 (0)