Remove slurpRemainder TODO from (*ZoneParser).Next (#1508)

tmthrgd · web-flow · commit 5d3f81bc3481 · 2023-11-07T15:07:11.000+01:00
No one has complained about this in the four years it's been here. I
think we can safely accept this new behaviour.
diff --git a/scan.go b/scan.go
@@ -605,8 +605,6 @@ func (zp *ZoneParser) Next() (RR, bool) {
 			if !isPrivate && zp.c.Peek().token == "" {
 				// This is a dynamic update rr.
 
-				// TODO(tmthrgd): Previously slurpRemainder was only called
-				// for certain RR types, which may have been important.
 				if err := slurpRemainder(zp.c); err != nil {
 					return zp.setParseError(err.err, err.lex)
 				}

Original file line number	Diff line number	Diff line change
`@@ -605,8 +605,6 @@ func (zp *ZoneParser) Next() (RR, bool) {`
`605`	`605`	`if !isPrivate && zp.c.Peek().token == "" {`
`606`	`606`	`// This is a dynamic update rr.`
`607`	`607`
`608`		`- // TODO(tmthrgd): Previously slurpRemainder was only called`
`609`		`- // for certain RR types, which may have been important.`
`610`	`608`	`if err := slurpRemainder(zp.c); err != nil {`
`611`	`609`	`return zp.setParseError(err.err, err.lex)`
`612`	`610`	`}`