Skip to content

Commit 6142d16

Browse files
DevMello4meav
andauthored
fix: remove duplicate pitch adjustment and replace hardcoded message (#506)
* fix: replace hardcoded 'no voices available' and 'No voices were found...' message with localization key and remove duplicate pitch adjustment * fix: add hint for custom voice entry in no voices available message --------- Co-authored-by: 4meav <py96982015@gmail.com>
1 parent 252ca8e commit 6142d16

3 files changed

Lines changed: 7 additions & 24 deletions

File tree

apps/stage-tamagotchi/src/pages/settings/modules/speech.vue

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -359,10 +359,11 @@ function updateCustomModelName(value: string) {
359359
<!-- No voices available -->
360360
<Alert v-else type="warning">
361361
<template #title>
362-
No voices available
362+
{{ t('settings.pages.modules.speech.sections.section.provider-voice-selection.no_voices') }}
363363
</template>
364364
<template #content>
365-
No voices were found for this provider. You can enter a custom voice name below.
365+
{{ t('settings.pages.modules.speech.sections.section.provider-voice-selection.no_voices_description') }}.
366+
{{ t('settings.pages.modules.speech.sections.section.provider-voice-selection.no_voices_hint') }}
366367
</template>
367368
</Alert>
368369

@@ -416,16 +417,6 @@ function updateCustomModelName(value: string) {
416417
</option>
417418
</select>
418419
</div>
419-
420-
<div flex="~ col gap-4">
421-
<FieldRange
422-
v-model="pitch"
423-
label="Pitch"
424-
description="Tune the pitch of the voice"
425-
:min="-100" :max="100" :step="1"
426-
:format-value="value => `${value}%`"
427-
/>
428-
</div>
429420
</div>
430421
</div>
431422
</div>

apps/stage-web/src/pages/settings/modules/speech.vue

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,11 @@ function updateCustomModelName(value: string) {
351351
class="mb-2"
352352
>
353353
<template #title>
354-
No voices available
354+
{{ t('settings.pages.modules.speech.sections.section.provider-voice-selection.no_voices') }}
355355
</template>
356356
<template #content>
357-
No voices were found for this provider. You can enter a custom voice name below.
357+
{{ t('settings.pages.modules.speech.sections.section.provider-voice-selection.no_voices_description') }}.
358+
{{ t('settings.pages.modules.speech.sections.section.provider-voice-selection.no_voices_hint') }}
358359
</template>
359360
</Alert>
360361

@@ -408,16 +409,6 @@ function updateCustomModelName(value: string) {
408409
</option>
409410
</select>
410411
</div>
411-
412-
<div flex="~ col gap-4">
413-
<FieldRange
414-
v-model="pitch"
415-
label="Pitch"
416-
description="Tune the pitch of the voice"
417-
:min="-100" :max="100" :step="1"
418-
:format-value="value => `${value}%`"
419-
/>
420-
</div>
421412
</div>
422413
</div>
423414
</div>

packages/i18n/src/locales/en/settings.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ pages:
225225
no_models_description: No models were found for this provider
226226
no_voices: No voices available
227227
no_voices_description: No voices were found for this provider
228+
no_voices_hint: You can enter a custom voice name below.
228229
pause: Pause
229230
play_sample: Play Sample
230231
search_models_placeholder: Search models...

0 commit comments

Comments
 (0)