HBASE-28754 verify the first argument passed to compaction_switch (apache#6119)

Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>

Author: ether1984

hbase-shell/src/main/ruby/hbase/admin.rb

@@ -114,6 +114,9 @@ def compact(table_or_region_name, family = nil, type = 'NORMAL')
     #----------------------------------------------------------------------------------------------
     # Switch compaction on/off at runtime on a region server
     def compaction_switch(on_or_off, regionserver_names)
+      unless /true|false/i.match(on_or_off.to_s)
+        raise ArgumentError, 'compaction_switch first argument only accepts "true" or "false"'
+      end
       region_servers = regionserver_names.flatten.compact
       servers = java.util.ArrayList.new
       if region_servers.any?

hbase-shell/src/test/ruby/hbase/admin_test.rb

@@ -150,6 +150,14 @@ def teardown
       command(:compaction_state, 'hbase:meta')
     end
 
+    #-------------------------------------------------------------------------------
+    define_test "compaction_switch should work" do
+      output = capture_stdout { command(:compaction_switch, false) }
+      assert(output.include?('PREV_STATE'))
+      output = capture_stdout { command(:compaction_switch, 'true') }
+      assert(output.include?('PREV_STATE'))
+    end
+
     #-------------------------------------------------------------------------------
 
     define_test "major_compact should work" do

hbase-shell/src/test/ruby/shell/commands_test.rb

@@ -69,6 +69,12 @@ def setup
     output = capture_stdout { @shell.command(name) }
     assert_match(/For usage try 'help "#{name}"'/, output)
   end
+
+  define_test 'Erroneous first argument for compaction_switch should indicate correct usage' do
+    name = :compaction_switch
+    output = capture_stdout { @shell.command(name, 'test') }
+    assert_match(/compaction_switch first argument only accepts "true" or "false"/, output)
+  end
 end
 
 ##