Skip to content

Commit b3da335

Browse files
committed
ci: minor cleanup
1 parent c4e8d43 commit b3da335

2 files changed

Lines changed: 4 additions & 10 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ jobs:
6565
6666
- name: List versions
6767
if: env.CI_SKIP == 'false'
68-
continue-on-error: true
6968
run: |
7069
pwd && ls -la
7170
@@ -100,8 +99,8 @@ jobs:
10099
npm run test:coverage
101100
102101
- name: Upload coverage to codecov
103-
uses: codecov/codecov-action@v1
104102
if: env.CI_SKIP == 'false' && contains(matrix.os, 'ubuntu') && success()
103+
uses: codecov/codecov-action@v1
105104
with:
106105
token: ${{ secrets.CODECOV_TOKEN }}
107106
file: ./coverage/lcov.info

.github/workflows/publish.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ defaults:
1111
run:
1212
shell: bash
1313

14+
env:
15+
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
16+
1417
jobs:
1518
build:
1619
name: ${{ matrix.os }} ${{ matrix.target }}
@@ -44,16 +47,12 @@ jobs:
4447
run: |
4548
npm config list
4649
npm publish . --tag=next
47-
env:
48-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
4950
5051
- name: Publish to npm
5152
if: contains(github.ref, '-') == false
5253
run: |
5354
npm config list
5455
npm publish .
55-
env:
56-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
5756
5857
# See https://github.com/actions/setup-node/issues/73.
5958
# - name: Setup node@${{ matrix.target }}
@@ -68,13 +67,9 @@ jobs:
6867
# run: |
6968
# npm config list
7069
# npm publish . --tag=next
71-
# env:
72-
# NODE_AUTH_TOKEN: ${{github.token}}
7370

7471
# - name: Publish to GPR
7572
# if: success() && contains(github.ref, '-') == false
7673
# run: |
7774
# npm config list
7875
# npm publish .
79-
# env:
80-
# NODE_AUTH_TOKEN: ${{github.token}}

0 commit comments

Comments
 (0)