https: remove closeIdleConnections function while calling server close

kumarrishav · web-flow · commit 37b3e06436ed · 2024-04-02T16:34:22.000-05:00
Correcting the #50194 backporting mistake. server.closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above. fixes: #52330, #51677,
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -506,7 +506,6 @@ function setupConnectionsTracking() {
 }
 
 function httpServerPreClose(server) {
-  server.closeIdleConnections();
   clearInterval(server[kConnectionsCheckingInterval]);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -506,7 +506,6 @@ function setupConnectionsTracking() {`
`506`	`506`	`}`
`507`	`507`
`508`	`508`	`function httpServerPreClose(server) {`
`509`		`- server.closeIdleConnections();`
`510`	`509`	`clearInterval(server[kConnectionsCheckingInterval]);`
`511`	`510`	`}`
`512`	`511`