http2: fix ping duration calculation

jasnell · BethGriggs · commit 5862d0372c26 · 2018-10-17T00:07:24.000+01:00
Backport-PR-URL: #22850 PR-URL: #19956 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -2832,8 +2832,8 @@ void Http2Session::Http2Ping::Send(uint8_t* payload) {
 }
 
 void Http2Session::Http2Ping::Done(bool ack, const uint8_t* payload) {
-  session_->statistics_.ping_rtt = (uv_hrtime() - startTime_);
-  double duration = (session_->statistics_.ping_rtt - startTime_) / 1e6;
+  session_->statistics_.ping_rtt = uv_hrtime() - startTime_;
+  double duration = session_->statistics_.ping_rtt / 1e6;
 
   Local<Value> buf = Undefined(env()->isolate());
   if (payload != nullptr) {

Original file line number	Diff line number	Diff line change
`@@ -2832,8 +2832,8 @@ void Http2Session::Http2Ping::Send(uint8_t* payload) {`
`2832`	`2832`	`}`
`2833`	`2833`
`2834`	`2834`	`void Http2Session::Http2Ping::Done(bool ack, const uint8_t* payload) {`
`2835`		`- session_->statistics_.ping_rtt = (uv_hrtime() - startTime_);`
`2836`		`- double duration = (session_->statistics_.ping_rtt - startTime_) / 1e6;`
	`2835`	`+ session_->statistics_.ping_rtt = uv_hrtime() - startTime_;`
	`2836`	`+ double duration = session_->statistics_.ping_rtt / 1e6;`
`2837`	`2837`
`2838`	`2838`	`Local<Value> buf = Undefined(env()->isolate());`
`2839`	`2839`	`if (payload != nullptr) {`