Skip to content

Commit e9afdae

Browse files
committed
build: default small-icu for win dll & package
Change the Windows .dll builds to include small-icu by default for parity with the regular and msi build options.
1 parent ed7bfb5 commit e9afdae

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

vcbuild.bat

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ if /i "%1"=="test-pummel" set test_args=%test_args% pummel&goto arg-ok
6868
if /i "%1"=="test-all" set test_args=%test_args% sequential parallel message gc internet pummel&set buildnodeweak=1&set jslint=1&goto arg-ok
6969
if /i "%1"=="test-known-issues" set test_args=%test_args% known_issues --expect-fail&goto arg-ok
7070
if /i "%1"=="jslint" set jslint=1&goto arg-ok
71-
if /i "%1"=="package" set package=1&goto arg-ok
71+
if /i "%1"=="package" set package=1&set download_arg="--download=all"&set i18n_arg=small-icu&goto arg-ok
7272
if /i "%1"=="msi" set msi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=small-icu&goto arg-ok
7373
if /i "%1"=="build-release" set build_release=1&goto arg-ok
7474
if /i "%1"=="upload" set upload=1&goto arg-ok
@@ -78,7 +78,7 @@ if /i "%1"=="intl-none" set i18n_arg=%1&goto arg-ok
7878
if /i "%1"=="download-all" set download_arg="--download=all"&goto arg-ok
7979
if /i "%1"=="ignore-flaky" set test_args=%test_args% --flaky-tests=dontcare&goto arg-ok
8080
if /i "%1"=="enable-vtune" set enable_vtune_profiling="--enable-vtune-profiling"&goto arg-ok
81-
if /i "%1"=="dll" set dll=1&goto arg-ok
81+
if /i "%1"=="dll" set dll=1&set download_arg="--download=all"&set i18n_arg=small-icu&goto arg-ok
8282

8383
echo Error: invalid command line option `%1`.
8484
exit /b 1

0 commit comments

Comments
 (0)