fix: only iterate the main executable program headers

RaisinTen · RaisinTen · commit 35a279ff390d · 2023-03-02T11:32:49.000+05:30
The resource gets injected in the main executable, so there is no need to iterate the other shared libraries that are loaded by the program. This also resolves a security concern. Refs: #77 (review) Signed-off-by: Darshan Sen <raisinten@gmail.com>
diff --git a/postject-api.h b/postject-api.h
@@ -91,8 +91,9 @@ static int postject__dl_iterate_phdr_callback(struct dl_phdr_info* info,
     }
   }
 
-  // skip to the next shared object
-  return 0;
+  // wasn't able to find the note in the main executable program headers, so
+  // terminate the search
+  return 1;
 }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,9 @@ static int postject__dl_iterate_phdr_callback(struct dl_phdr_info* info,`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`
`94`		`- // skip to the next shared object`
`95`		`- return 0;`
	`94`	`+ // wasn't able to find the note in the main executable program headers, so`
	`95`	`+ // terminate the search`
	`96`	`+ return 1;`
`96`	`97`	`}`
`97`	`98`	`#endif`
`98`	`99`