Skip to content

Commit 1975181

Browse files
authored
fix(core): replace require(path/posix) for better node compatibility range (#15307)
1 parent 22970b8 commit 1975181

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

packages/nx/src/utils/ignore.ts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { readFileSync } from 'fs-extra';
22
import ignore from 'ignore';
3-
import { join } from 'path/posix';
43
import { readFileIfExisting } from './fileutils';
4+
import { joinPathFragments } from './path';
55
import { workspaceRoot } from './workspace-root';
66

77
/**
@@ -18,19 +18,23 @@ export function getIgnoredGlobs(
1818
if (prependRoot) {
1919
return [
2020
...getAlwaysIgnore(root),
21-
...files.flatMap((f) => getIgnoredGlobsFromFile(join(root, f), root)),
21+
...files.flatMap((f) =>
22+
getIgnoredGlobsFromFile(joinPathFragments(root, f), root)
23+
),
2224
];
2325
} else {
2426
return [
2527
...getAlwaysIgnore(),
26-
...files.flatMap((f) => getIgnoredGlobsFromFile(join(root, f))),
28+
...files.flatMap((f) =>
29+
getIgnoredGlobsFromFile(joinPathFragments(root, f))
30+
),
2731
];
2832
}
2933
}
3034

3135
export function getAlwaysIgnore(root?: string) {
3236
const paths = ['node_modules', '**/node_modules', '.git'];
33-
return root ? paths.map((x) => join(root, x)) : paths;
37+
return root ? paths.map((x) => joinPathFragments(root, x)) : paths;
3438
}
3539

3640
export function getIgnoreObject(root: string = workspaceRoot) {
@@ -51,9 +55,9 @@ function getIgnoredGlobsFromFile(file: string, root?: string): string[] {
5155
continue;
5256
} else if (trimmed.startsWith('/')) {
5357
if (root) {
54-
results.push(join(root, trimmed));
58+
results.push(joinPathFragments(root, trimmed));
5559
} else {
56-
results.push(join('.', trimmed));
60+
results.push(joinPathFragments('.', trimmed));
5761
}
5862
} else {
5963
results.push(trimmed);

0 commit comments

Comments
 (0)