Use batch SSH for upstream status fetches

- Add `core.sshCommand=ssh -o BatchMode=yes` to `git fetch` used for upstream status refresh
- Update tests to assert the new fetch invocation

Author: merrkry

apps/server/src/git/Layers/GitCore.test.ts

@@ -759,7 +759,7 @@ it.layer(TestLayer)("git integration", (it) => {
         const realGitCore = yield* GitCore;
         let refreshFetchAttempts = 0;
         const core = yield* makeIsolatedGitCore((input) => {
-          if (input.args[0] === "--git-dir" && input.args[2] === "fetch") {
+          if (input.operation === "GitCore.fetchUpstreamRefForStatus") {
             refreshFetchAttempts += 1;
             return Effect.fail(
               new GitCommandError({
@@ -805,7 +805,7 @@ it.layer(TestLayer)("git integration", (it) => {
         const realGitCore = yield* GitCore;
         let refreshFetchAttempts = 0;
         const core = yield* makeIsolatedGitCore((input) => {
-          if (input.args[0] === "--git-dir" && input.args[2] === "fetch") {
+          if (input.operation === "GitCore.fetchUpstreamRefForStatus") {
             refreshFetchAttempts += 1;
             return Effect.succeed({
               code: 0,
@@ -853,7 +853,7 @@ it.layer(TestLayer)("git integration", (it) => {
           if (input.args[0] === "rev-parse" && input.args[1] === "--git-common-dir") {
             return ok("/repo/.git\n");
           }
-          if (input.args[0] === "--git-dir" && input.args[2] === "fetch") {
+          if (input.operation === "GitCore.fetchUpstreamRefForStatus") {
             fetchCount += 1;
             expect(input.cwd).toBe("/repo");
             return ok();
@@ -913,7 +913,7 @@ it.layer(TestLayer)("git integration", (it) => {
           if (input.args[0] === "rev-parse" && input.args[1] === "--git-common-dir") {
             return ok("/repo/.git\n");
           }
-          if (input.args[0] === "--git-dir" && input.args[2] === "fetch") {
+          if (input.operation === "GitCore.fetchUpstreamRefForStatus") {
             fetchCount += 1;
             return Effect.fail(
               new GitCommandError({
@@ -1024,7 +1024,7 @@ it.layer(TestLayer)("git integration", (it) => {
         const realGitCore = yield* GitCore;
         let fetchArgs: readonly string[] | null = null;
         const core = yield* makeIsolatedGitCore((input) => {
-          if (input.args[0] === "--git-dir" && input.args[2] === "fetch") {
+          if (input.operation === "GitCore.fetchUpstreamRefForStatus") {
             fetchArgs = [...input.args];
             return Effect.succeed({
               code: 0,
@@ -1041,6 +1041,8 @@ it.layer(TestLayer)("git integration", (it) => {
         expect(status.branch).toBe("upstream/feature");
         expect(status.upstreamRef).toBe(`${remoteName}/${featureBranch}`);
         expect(fetchArgs).toEqual([
+          "-c",
+          "core.sshCommand=ssh -o BatchMode=yes",
           "--git-dir",
           path.join(source, ".git"),
           "fetch",

apps/server/src/git/Layers/GitCore.ts

@@ -929,7 +929,17 @@ export const makeGitCore = Effect.fn("makeGitCore")(function* (options?: {
     return executeGit(
       "GitCore.fetchUpstreamRefForStatus",
       fetchCwd,
-      ["--git-dir", gitCommonDir, "fetch", "--quiet", "--no-tags", upstream.remoteName, refspec],
+      [
+        "-c",
+        "core.sshCommand=ssh -o BatchMode=yes",
+        "--git-dir",
+        gitCommonDir,
+        "fetch",
+        "--quiet",
+        "--no-tags",
+        upstream.remoteName,
+        refspec,
+      ],
       {
         allowNonZeroExit: true,
         timeoutMs: Duration.toMillis(STATUS_UPSTREAM_REFRESH_TIMEOUT),