Merge pull request #266 from plotly/pr-bump-electron-6

bump electron to 6.1.4

Author: antoinerg

.circleci/config.yml

@@ -32,6 +32,9 @@ workflows:
       - test-image:
           requires:
             - docker-build-and-push
+      - test-dash-preview:
+          requires:
+            - docker-build-and-push
 
 version: 2
 jobs:
@@ -83,6 +86,7 @@ jobs:
           command: npm run coverage
       - store_artifacts:
           path: build
+          destination: /
 
   test-node-v6:
     <<: *base
@@ -103,7 +107,24 @@ jobs:
           name: Run image test
           command: ./.circleci/test-image.sh
       - store_artifacts:
-          path: build/
+          path: build
+          destination: /
+
+  test-dash-preview:
+    docker:
+      - image: quay.io/plotly/image-exporter:$CIRCLE_SHA1
+      - image: quay.io/plotly/image-exporter:$CIRCLE_SHA1
+        environment:
+          LIBGL_ALWAYS_SOFTWARE: true
+          GALLIUM_DRIVER: softpipe
+    steps:
+      - checkout
+      - run:
+          name: Run dash-preview test
+          command: ./.circleci/test-dash-preview.sh
+      - store_artifacts:
+          path: build
+          destination: /
 
   docker-build-and-push:
     docker:
@@ -236,3 +257,4 @@ jobs:
             zip -r artifacts/conda-linux-64.zip ./linux-64
       - store_artifacts:
           path: artifacts
+          destination: /

.circleci/test-dash-preview.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+# override CircleCi's default run settings,
+# so that we run all tests and do not exit early
+# on test failures.
+set +e
+set +o pipefail
+
+./test/dash-preview/render_mocks_cli build/test_dash_previews
+#./test/image/compare_images test/image/baselines build/test_images build/test_images_diff

CONTRIBUTING.md

@@ -94,7 +94,7 @@ docker build -t "$DOCKER_ORCA_IMAGE" -f deployment/Dockerfile .
 To run the image tests, run the following:
 ```
 ./test/image/render_mocks_cli build/test_images "$DOCKER_ORCA_IMAGE" && \
-./test/image/compare_images test/image/baselines build/test_images build/
+./test/image/compare_images test/image/baselines build/test_images build/test_images_diff
 ```
 
 #### Generate new baselines

README.md

@@ -31,7 +31,7 @@ If you have Node.js installed (recommended v8.x), you can easily install Orca
 using npm as:
 
 ```
-$ npm install -g electron@1.8.4 orca
+$ npm install -g electron@6.1.4 orca
 ```
 
 which makes the `orca` executable available in your path.

bin/orca.js

@@ -8,4 +8,8 @@ const args = process.argv.slice(2)
 const pathToMain = path.join(__dirname, 'orca_electron.js')
 args.unshift(path.resolve(pathToMain))
 
+// Sandbox is enabled by default since electron v5
+// Fix sandbox issue (https://github.com/electron/electron/issues/17972)
+args.push('--no-sandbox')
+
 spawn(electronPath, args, { stdio: 'inherit' })