Fix Android audio crash fixes Issue #1417#1529
Fix Android audio crash fixes Issue #1417#1529cobarx merged 2 commits intoTheWidlarzGroup:masterfrom
Conversation
Why: * There is a case where groupIndex may be unset This change addresses the need by: * Don't chain check for INDEX_UNSET to previous conditional
Mrjaco12
changed the title
|
@Mrjaco12 ❤️ I can confirm the fix works, tested on android 9 (nokia 7+) with |
|
Good job. |
|
@cobarx hey, any chance to have a look at this? Also any chance to reply to @kelset related to the React Native Core Contributors org we're trying to setup (well, he's doing all the work)? 🤗 https://github.com/react-native-community/meta/blob/master/MAINTAINERS.md |
|
Nice! |
|
Ok sorry for the delay on this, I haven't been as active lately. Yes, this will work. It took me a bit of looking but you were right on the money. The nested check whether there are video groups or not through me for a loop on why unchaining worked. So I moved that into the main if check to make that more readable and added some comments. I'll reach out to @kelset tonight. |
5 participants
Fix Issue #1417
Why:
It appears that in this commit the check added to ensure group lengths are greater than 0 still allows for a case in which the groupIndex is -1 but the group.length == 0 so we are never breaking for the invalid groupIndex.
This change addresses the need by: