Skip to content

Commit b655a25

Browse files
committed
Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
rectorphp/rector-src@81e8c74 [NodeManipulator] Use ReflectionResolver instead of BetterNodeFinder parent lookup on ClassMethodManipulator (#4035)
1 parent a31c14f commit b655a25

6 files changed

Lines changed: 17 additions & 24 deletions

File tree

src/Application/VersionResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ final class VersionResolver
1919
* @api
2020
* @var string
2121
*/
22-
public const PACKAGE_VERSION = '98fa6b51c4114010cb45c7f07ad96256430bf605';
22+
public const PACKAGE_VERSION = '81e8c74b0ea2a107db681ee21c13925837b84abc';
2323
/**
2424
* @api
2525
* @var string
2626
*/
27-
public const RELEASE_DATE = '2023-05-31 13:13:35';
27+
public const RELEASE_DATE = '2023-05-31 13:15:27';
2828
/**
2929
* @var int
3030
*/

src/Kernel/RectorKernel.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ final class RectorKernel
1515
/**
1616
* @var string
1717
*/
18-
private const CACHE_KEY = 'v42';
18+
private const CACHE_KEY = 'v43';
1919
/**
2020
* @var \Symfony\Component\DependencyInjection\ContainerInterface|null
2121
*/

src/NodeManipulator/ClassMethodManipulator.php

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,11 @@
66
use PhpParser\Node\Stmt\Class_;
77
use PhpParser\Node\Stmt\ClassMethod;
88
use PHPStan\Reflection\ClassReflection;
9-
use Rector\Core\PhpParser\Node\BetterNodeFinder;
109
use Rector\Core\Reflection\ReflectionResolver;
1110
use Rector\Core\ValueObject\MethodName;
1211
use Rector\NodeNameResolver\NodeNameResolver;
1312
final class ClassMethodManipulator
1413
{
15-
/**
16-
* @readonly
17-
* @var \Rector\Core\PhpParser\Node\BetterNodeFinder
18-
*/
19-
private $betterNodeFinder;
2014
/**
2115
* @readonly
2216
* @var \Rector\NodeNameResolver\NodeNameResolver
@@ -27,9 +21,8 @@ final class ClassMethodManipulator
2721
* @var \Rector\Core\Reflection\ReflectionResolver
2822
*/
2923
private $reflectionResolver;
30-
public function __construct(BetterNodeFinder $betterNodeFinder, NodeNameResolver $nodeNameResolver, ReflectionResolver $reflectionResolver)
24+
public function __construct(NodeNameResolver $nodeNameResolver, ReflectionResolver $reflectionResolver)
3125
{
32-
$this->betterNodeFinder = $betterNodeFinder;
3326
$this->nodeNameResolver = $nodeNameResolver;
3427
$this->reflectionResolver = $reflectionResolver;
3528
}
@@ -38,14 +31,14 @@ public function isNamedConstructor(ClassMethod $classMethod) : bool
3831
if (!$this->nodeNameResolver->isName($classMethod, MethodName::CONSTRUCT)) {
3932
return \false;
4033
}
41-
$class = $this->betterNodeFinder->findParentType($classMethod, Class_::class);
42-
if (!$class instanceof Class_) {
34+
$classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
35+
if (!$classReflection instanceof ClassReflection) {
4336
return \false;
4437
}
4538
if ($classMethod->isPrivate()) {
4639
return \true;
4740
}
48-
if ($class->isFinal()) {
41+
if ($classReflection->isFinalByKeyword()) {
4942
return \false;
5043
}
5144
return $classMethod->isProtected();

vendor/autoload.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@
2222

2323
require_once __DIR__ . '/composer/autoload_real.php';
2424

25-
return ComposerAutoloaderInit731739b266fe641fa1d637c18a956e3d::getLoader();
25+
return ComposerAutoloaderInit79d6ac6df0b20288ba3e1e8745c6e242::getLoader();

vendor/composer/autoload_real.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
// autoload_real.php @generated by Composer
44

5-
class ComposerAutoloaderInit731739b266fe641fa1d637c18a956e3d
5+
class ComposerAutoloaderInit79d6ac6df0b20288ba3e1e8745c6e242
66
{
77
private static $loader;
88

@@ -22,17 +22,17 @@ public static function getLoader()
2222
return self::$loader;
2323
}
2424

25-
spl_autoload_register(array('ComposerAutoloaderInit731739b266fe641fa1d637c18a956e3d', 'loadClassLoader'), true, true);
25+
spl_autoload_register(array('ComposerAutoloaderInit79d6ac6df0b20288ba3e1e8745c6e242', 'loadClassLoader'), true, true);
2626
self::$loader = $loader = new \Composer\Autoload\ClassLoader(\dirname(__DIR__));
27-
spl_autoload_unregister(array('ComposerAutoloaderInit731739b266fe641fa1d637c18a956e3d', 'loadClassLoader'));
27+
spl_autoload_unregister(array('ComposerAutoloaderInit79d6ac6df0b20288ba3e1e8745c6e242', 'loadClassLoader'));
2828

2929
require __DIR__ . '/autoload_static.php';
30-
call_user_func(\Composer\Autoload\ComposerStaticInit731739b266fe641fa1d637c18a956e3d::getInitializer($loader));
30+
call_user_func(\Composer\Autoload\ComposerStaticInit79d6ac6df0b20288ba3e1e8745c6e242::getInitializer($loader));
3131

3232
$loader->setClassMapAuthoritative(true);
3333
$loader->register(true);
3434

35-
$filesToLoad = \Composer\Autoload\ComposerStaticInit731739b266fe641fa1d637c18a956e3d::$files;
35+
$filesToLoad = \Composer\Autoload\ComposerStaticInit79d6ac6df0b20288ba3e1e8745c6e242::$files;
3636
$requireFile = \Closure::bind(static function ($fileIdentifier, $file) {
3737
if (empty($GLOBALS['__composer_autoload_files'][$fileIdentifier])) {
3838
$GLOBALS['__composer_autoload_files'][$fileIdentifier] = true;

vendor/composer/autoload_static.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace Composer\Autoload;
66

7-
class ComposerStaticInit731739b266fe641fa1d637c18a956e3d
7+
class ComposerStaticInit79d6ac6df0b20288ba3e1e8745c6e242
88
{
99
public static $files = array (
1010
'ad155f8f1cf0d418fe49e248db8c661b' => __DIR__ . '/..' . '/react/promise/src/functions_include.php',
@@ -3062,9 +3062,9 @@ class ComposerStaticInit731739b266fe641fa1d637c18a956e3d
30623062
public static function getInitializer(ClassLoader $loader)
30633063
{
30643064
return \Closure::bind(function () use ($loader) {
3065-
$loader->prefixLengthsPsr4 = ComposerStaticInit731739b266fe641fa1d637c18a956e3d::$prefixLengthsPsr4;
3066-
$loader->prefixDirsPsr4 = ComposerStaticInit731739b266fe641fa1d637c18a956e3d::$prefixDirsPsr4;
3067-
$loader->classMap = ComposerStaticInit731739b266fe641fa1d637c18a956e3d::$classMap;
3065+
$loader->prefixLengthsPsr4 = ComposerStaticInit79d6ac6df0b20288ba3e1e8745c6e242::$prefixLengthsPsr4;
3066+
$loader->prefixDirsPsr4 = ComposerStaticInit79d6ac6df0b20288ba3e1e8745c6e242::$prefixDirsPsr4;
3067+
$loader->classMap = ComposerStaticInit79d6ac6df0b20288ba3e1e8745c6e242::$classMap;
30683068

30693069
}, null, ClassLoader::class);
30703070
}

0 commit comments

Comments
 (0)